Skip to content

Feat: Multiple selection of media in gutenberg#12404

Merged
pinarol merged 17 commits intowordpress-mobile:developfrom
callstack:feature/media-upload-multiple
Oct 2, 2019
Merged

Feat: Multiple selection of media in gutenberg#12404
pinarol merged 17 commits intowordpress-mobile:developfrom
callstack:feature/media-upload-multiple

Conversation

@dratwas
Copy link
Copy Markdown
Contributor

@dratwas dratwas commented Aug 27, 2019 •
edited
Loading

In this PR I added the possibility to set multiple media when inserting to the block.
Related gutenberg-mobile PR wordpress-mobile/gutenberg-mobile#1331
To test:
At this moment we don't support gallery block so this change can not be tested without changes in gutenberg-mobile JS bundle. In the future, we will use this functionality to multiple selections of media for the gallery.

  • set multiple prop to true in media-upload bloc
  • add image/video block - multiple select should be enabled for selecting media from the device or WP Media
  • the array of selected media should be passed to the callback function

houndci-bot
houndci-bot reviewed Aug 27, 2019
View reviewed changes
@dratwas dratwas mentioned this pull request Aug 27, 2019
Merged
@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Sep 13, 2019

I see that this is a draft but the gutenberg-mobile PR looks ready to review. Is this still work in progress? If yes, you might want to mark gutenberg-mobile PR as Not Ready to Review as well, because reviewers won't be able to test it anyway.

@dratwas dratwas marked this pull request as ready for review September 16, 2019 12:00
@dratwas
Copy link
Copy Markdown
Contributor Author

dratwas commented Sep 16, 2019

Hi all, this PR is ready. Could you please make a CR?

pinarol
pinarol approved these changes Sep 24, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, thanks! 🎉

@pinarol pinarol assigned pinarol and dratwas and unassigned pinarol Sep 24, 2019
@pinarol pinarol added the Gutenberg Editing and display of Gutenberg blocks. label Sep 24, 2019
@pinarol pinarol added this to the 13.4 milestone Sep 24, 2019
@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Sep 24, 2019

Interestingly CI fails with error:

...
^D��^D��Cloning into '.'...
Warning: Permanently added the RSA host key for IP address '192.30.253.113' to the list of known hosts.

agent key RSA SHA256:oEdX/44m2Y1klY5Uq287qOWuWfJrhusv4e5ImKQ5Uhk returned incorrect signature type

warning: Could not find remote branch pull/12404 to clone.
fatal: Remote branch pull/12404 not found in upstream origin
Exited with code 128

@jtreanor maybe you know this, this PR uses another fork. Is this expected?

@jtreanor
Copy link
Copy Markdown
Contributor

jtreanor commented Sep 25, 2019

@pinarol Thanks for the heads up. It looks like the CI failure is a configuration issue on our part. A recent change doesn't seem to be working correctly. I will look into a solution for it and update here.

@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Sep 25, 2019

thank you @jtreanor 👍

This was referenced Sep 25, 2019
Closed
Merged
@pinarol
Copy link
Copy Markdown
Contributor

pinarol commented Sep 27, 2019

Could you update your branch from latest develop? @dratwas After that CI should be working

@pinarol pinarol merged commit a2a5e52 into wordpress-mobile:develop Oct 2, 2019
pinarol added a commit that referenced this pull request Oct 2, 2019
@pinarol
Revert "Feat: Multiple selection of media in gutenberg (#12404)"
bbad25c 
This reverts commit a2a5e52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinarol pinarol pinarol approved these changes

+1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dratwas dratwas

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

13.4

Development

Successfully merging this pull request may close these issues.

4 participants

@dratwas @pinarol @jtreanor @houndci-bot