Skip to content

Fix deep linking in marketing emails#11855

Merged
diegoreymendez merged 8 commits intodevelopfrom
issue/11693-fix-deep-linking-in-marketing-emails
Jul 1, 2019
Merged

Fix deep linking in marketing emails#11855
diegoreymendez merged 8 commits intodevelopfrom
issue/11693-fix-deep-linking-in-marketing-emails

Conversation

@diegoreymendez
Copy link
Copy Markdown
Contributor

@diegoreymendez diegoreymendez commented Jun 4, 2019

This PR does 2 things:

Details:

This PR implements the code to handle /mbar redirects, such as:

https://public-api.wordpress.com/mbar/?redirect_to=https%3A%2F%2Fwordpress.com%2Fpost%2Fddancestore.wordpress.com

We've also added an AASA file to public-api.wordpress.com (ref: pMz3w-a0N-p2).

Dependencies:

This PR has a dependency on: #11851

Matching Android PR:

wordpress-mobile/WordPress-Android#9957

Testing:

Make sure you erase all content and settings from your simulator before testing. This ensures the newly installed App picks up the AASA file from public-api.wordpress.com.

Test 1:

  1. Create WP.com site.
  2. Publish a post in that site.
  3. Check that you received the "Congratulations on your first post!" email for the new site.
  4. Tap on the blue "Start a New Post" button.
  5. Make sure the editor is opened in-App.

Test 2:

  1. Launch the app.
  2. Make sure you're logged in.
  3. Enter this in a terminal window after replacing the blog name: xcrun simctl openurl booted https://public-api.wordpress.com/mbar/?redirect_to=https%3A%2F%2Fwordpress.com%2Fpost%2Fdiegotest4.wordpress.com
  4. Make sure a new post is created in the App for the specified blog.

Additionally you can place breakpoints here to make sure the full URL is tracked, but the final redirect isn't.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@peril-wordpress-mobile
Copy link
Copy Markdown

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@diegoreymendez
Copy link
Copy Markdown
Contributor Author

fyi @maxme

@diegoreymendez
Copy link
Copy Markdown
Contributor Author

This PR is waiting for a resolution on pMz3w-a0N-p2 before it can be reviewed.

@diegoreymendez diegoreymendez requested a review from frosty June 28, 2019 13:33
@diegoreymendez diegoreymendez marked this pull request as ready for review June 28, 2019 13:33
Copy link
Copy Markdown
Contributor

@frosty frosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and working great!

@diegoreymendez diegoreymendez merged commit 9a6acaf into develop Jul 1, 2019
@diegoreymendez
Copy link
Copy Markdown
Contributor Author

Thanks @frosty !

@diegoreymendez diegoreymendez deleted the issue/11693-fix-deep-linking-in-marketing-emails branch July 1, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Site Creation: Fix deep linking in first-post congratulations email.

2 participants