Fix deep linking in marketing emails#11855
Merged
diegoreymendez merged 8 commits intodevelopfrom Jul 1, 2019
Merged
Conversation
Generated by 🚫 dangerJS |
Contributor
Author
|
fyi @maxme |
Contributor
Author
|
This PR is waiting for a resolution on pMz3w-a0N-p2 before it can be reviewed. |
frosty
approved these changes
Jun 28, 2019
Contributor
frosty
left a comment
There was a problem hiding this comment.
Changes look good and working great!
Contributor
Author
|
Thanks @frosty ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
Details:
This PR implements the code to handle
/mbarredirects, such as:https://public-api.wordpress.com/mbar/?redirect_to=https%3A%2F%2Fwordpress.com%2Fpost%2Fddancestore.wordpress.comWe've also added an AASA file to
public-api.wordpress.com(ref: pMz3w-a0N-p2).Dependencies:
This PR has a dependency on: #11851
Matching Android PR:
wordpress-mobile/WordPress-Android#9957
Testing:
Make sure you erase all content and settings from your simulator before testing. This ensures the newly installed App picks up the AASA file from public-api.wordpress.com.
Test 1:
Test 2:
xcrun simctl openurl booted https://public-api.wordpress.com/mbar/?redirect_to=https%3A%2F%2Fwordpress.com%2Fpost%2Fdiegotest4.wordpress.comAdditionally you can place breakpoints here to make sure the full URL is tracked, but the final redirect isn't.
Update release notes:
RELEASE-NOTES.txt.