Make universal link router values non optional#11851
Merged
diegoreymendez merged 3 commits intodevelopfrom Jun 5, 2019
Merged
Conversation
1 task
frosty
approved these changes
Jun 5, 2019
Contributor
frosty
left a comment
There was a problem hiding this comment.
Looks good! Builds and tests pass ✅
Contributor
Author
|
Ty @frosty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UniversalLinkRoutervalues were not optional even before this PR. TheNavigationActionprotocol was allowingvaluesto be optional, causing unnecessary overhead in the classes that implemented this protocol.This PR simply modifies the protocol so that the
valuesparameter is no longer optional, and changes the implementations of this protocol to adopt the change.Testing:
Make sure the code builds, and that unit tests don't fail.
Update release notes:
RELEASE-NOTES.txt.