Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier)#83

Merged
ParaskP7 merged 13 commits intotrunkfrom
update/gradle-to-7.3.3-agp-to-7.0.4
Mar 23, 2022
Merged

Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier)#83
ParaskP7 merged 13 commits intotrunkfrom
update/gradle-to-7.3.3-agp-to-7.0.4

Conversation

@ParaskP7
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 commented Mar 2, 2022

This PR upgrades Gradle to 7.4 & AGP to 7.1.1.

It includes the following:

  • Gradle version upgraded to 7.3.3 with the ./gradlew wrapper --gradle-version=7.3.3 --distribution-type=all command.
  • AGP version upgrade to 7.0.4 (see settings.gradle change).
  • Build output diff:
    • To identify and fix new warnings/errors that got added.
    • To identify and verify old warnings/errors that got removed.
  • Lint output diff
    • To identify and fix new warnings/errors that got added.
    • To identify and verify old warnings/errors that got removed.
  • The above 4 steps were redone with a follow-up update to Gradle 7.4 & AGP 7.1.1.
  • Disable jetifier.
  • Update buildkite docker android build image to 1.2.0.

It suppresses the following Lint issues:

It resolves the following Lint issues:


Besides the above, you can reference the Gradle 7.4 & AGP 7.1.1 PRs of the below clients for testing/verification purposes:

NOTE: This is a draft PR because all Gradle & AGP upgrade PRs need to be merged together.

Merge Instructions

To Test

  1. CI checks will cover everything in terms of testing.
  2. Testing composite builds and respective clients will be enough (see above).

ParaskP7 added 11 commits March 2, 2022 13:53
The 'com.dipien.byebyejetifier' plugin was used to determine whether
Jetifier can be disable for this project.

After configuring 'Bye Bye Jetifier' and running the below command:
./gradlew canISayByeByeJetifier -Pandroid.enableJetifier=false

The output was clear, Jetifier can be now safely disabled for this
project: > Task :canISayByeByeJetifier

=========================================
Project: :
=========================================
 * No legacy android support usages found

=========================================
Project: :WordPressLoginFlow
=========================================
 * No legacy android support usages found

===================================================== ...
* No dependencies with legacy android support usages! ...
===================================================== ...

... ===============================
... You can say Bye Bye Jetifier. *
... ===============================

> Task :WordPressLoginFlow:canISayByeByeJetifier

=========================================
Project: :WordPressLoginFlow
=========================================
 * No legacy android support usages found

===================================================== ...
* No dependencies with legacy android support usages! ...
===================================================== ...

... ===============================
... You can say Bye Bye Jetifier. *
... ===============================
@ParaskP7 ParaskP7 requested a review from oguzkocer March 2, 2022 12:32
@ParaskP7 ParaskP7 self-assigned this Mar 2, 2022
…low-Android into update/gradle-to-7.3.3-agp-to-7.0.4
@ParaskP7 ParaskP7 marked this pull request as ready for review March 18, 2022 17:18
@ParaskP7 ParaskP7 requested review from a team and removed request for oguzkocer March 18, 2022 17:18
@ParaskP7 ParaskP7 merged commit d4f9830 into trunk Mar 23, 2022
@ParaskP7 ParaskP7 deleted the update/gradle-to-7.3.3-agp-to-7.0.4 branch March 23, 2022 11:45
wzieba pushed a commit that referenced this pull request Oct 15, 2024
…gp-to-7.0.4

Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants