This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Merged
Conversation
…-Android into feature/support-private-at-sites
…-Android into feature/support-private-at-sites # Conflicts: # fluxc/src/main/java/org/wordpress/android/fluxc/persistence/WellSqlConfig.kt
…-Android into feature/support-private-at-sites # Conflicts: # fluxc/src/main/java/org/wordpress/android/fluxc/persistence/WellSqlConfig.kt
3 tasks
develric
approved these changes
Apr 15, 2020
Contributor
develric
left a comment
There was a problem hiding this comment.
Hi @khaykov 👋! Tested it with the companion PR and works as described, good job 👍!
Just to document a bit what we said in slack, it seems there is an inconsistency on the BE side that is marking a coming soon site as IS_PRIVATE but not IS_COMING_SOON. Meanwhile it becomes consistent in the BE, since you are checking this:
public boolean isPrivateWPComAtomic() {
return isWPComAtomic() && (isPrivate() || isComingSoon());
}
we should be safe and sound already 😊.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for retrieving and storing a cookie used to access media on private atomic sites.
It can be tested with this PR on client-side.
What changed: