Conversation
…er and media settings.
… the check to edit post activity.
…/wordpress-mobile/WordPress-Android into feature/support-private-at-sites
…/wordpress-mobile/WordPress-Android into feature/support-private-at-sites # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/PrivateAtCookieRefreshProgressDialog.kt
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
…/github.com/wordpress-mobile/WordPress-Android into feature/support-private-at-sites
|
You can test the changes on this Pull Request by downloading the APK here. |
…/github.com/wordpress-mobile/WordPress-Android into feature/support-private-at-sites
|
Hi @khaykov , was looking into this PR and was able to get the described scenarios to work correctly 👍; while looking into it I noticed the following and I thought to leave this quick note for you to double check. In the Posts list, if I ask for a VIEW on a published post or for a PREVIEW on a draft post I get something like the following: Let me know if I can help in reproducing in case it is setup specific 😊 |
|
Thank you, @develric ! A mistake on my part - I assumed Post preview is launched in the same way as site preview, but it's not. Added a private site id to post preview launcher, so it should work. Also fixed issue where site preview was always behaving thinking that the site is private. |
|
There is one hard to tackle issue - when you play with calypso settings while the app is open, the app can (and will) get out of sync with calypso. This affects all parts of our app, and I don't think there is much we can do at this point. |
…n it was previously fetched in editor.
develric
left a comment
There was a problem hiding this comment.
Hi @khaykov 👋! Thanks for the View/Preview modifications and for the additional follow up enhancements 🙇♂️!
Code LGTM; I've also tested:
✅ with AT private as per test steps
✅ View/Preview from posts list/editor
✅ with WP.com/JP/Pure self-hosted (no regression)
✅ Update script from previous version for wp-fluxc and wpreader DBs
and works as expected, good job 👍!
There is one hard to tackle issue - when you play with calypso settings while the app is open, the app can (and will) get out of sync with calypso. This affects all parts of our app, and I don't think there is much we can do at this point.
Agree this is a general issue and I noticed something similar related to the gravatar update sync in the app when changed from the web side, a wider scope thing we should think about.

This PR adds support for loading media from private Atomic sites.
Companion Flux-C PR needs to be merged first.
There are two main changes:
Since the use case for this is relatively small, I wanted to avoid adding too much new logic, and instead integrated the behavior into existing flow with (hopefully) minimal amount of interruption.
There are a couple of steps to test the changes:
Site preview:
Editor:
Reader:
When testing cookie authentication, you might encounter cookie loading with a modal dialog.
Cookie loading injects into normal content loading flow and interrupts it if necessary. Loading will continue as normal after the cookie is retrieved. A cookie Progress dialog is cancellable, and when canceled the normal flow of content render will resume.
PR submission checklist:
RELEASE-NOTES.txtif necessary.