This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Woo: Issue/1402 cache jetpack user email to SiteModel#1403
Merged
Conversation
# Conflicts: # fluxc/src/main/java/org/wordpress/android/fluxc/persistence/WellSqlConfig.java
Contributor
Author
|
Thanks for the quick review @0nko! I've fixed some merge conflicts from the main branch. PR ready for another round 👍 |
Contributor
|
I've fixed the conflicting version numbers, I hope you don't mind. I'm going to cut the beta release and I wanted to include this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1402 by adding the
jetpack_user_emailparam to the xmlrpcwp.getOptionsendpoint and storing locally.Testing
Sign inbutton in the example app.Sites -> Fetch first site.wp.getOptionsendpoint is called and thejetpack_user_emailcorresponding to the login credentials is received correctly.jetpack_user_emailis changed accordingly.Note that the
jetpack_user_emailfield would only be available in the API response if jetpack is installed, activated and connected.