Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

Woo: Issue/1402 cache jetpack user email to SiteModel#1403

Merged
0nko merged 5 commits intodevelopfrom
issue/1402-cache-jetpack-user-email
Oct 16, 2019
Merged

Woo: Issue/1402 cache jetpack user email to SiteModel#1403
0nko merged 5 commits intodevelopfrom
issue/1402-cache-jetpack-user-email

Conversation

@anitaa1990
Copy link
Copy Markdown
Contributor

Fixes #1402 by adding the jetpack_user_email param to the xmlrpc wp.getOptions endpoint and storing locally.

Testing

  • Click on the Sign in button in the example app.
  • Enter username, password and xmlrpc url for the site with Jetpack installed/activated/connected.
  • Once successfully logged in, click on Sites -> Fetch first site.
  • Verify that the xmlrpc wp.getOptions endpoint is called and the jetpack_user_email corresponding to the login credentials is received correctly.
  • Login with a different jetpack connected user for the same site and verify that the jetpack_user_email is changed accordingly.

Note that the jetpack_user_email field would only be available in the API response if jetpack is installed, activated and connected.

@anitaa1990 anitaa1990 requested review from 0nko and AmandaRiu October 16, 2019 07:39
@anitaa1990 anitaa1990 changed the title Issue/1402 cache jetpack user email to SiteModel Woo: Issue/1402 cache jetpack user email to SiteModel Oct 16, 2019
@0nko 0nko self-assigned this Oct 16, 2019
Copy link
Copy Markdown
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍. I'm going to wait for #1395 before merging this PR.

# Conflicts:
#	fluxc/src/main/java/org/wordpress/android/fluxc/persistence/WellSqlConfig.java
@anitaa1990
Copy link
Copy Markdown
Contributor Author

Thanks for the quick review @0nko! I've fixed some merge conflicts from the main branch. PR ready for another round 👍

@0nko
Copy link
Copy Markdown
Contributor

0nko commented Oct 16, 2019

I've fixed the conflicting version numbers, I hope you don't mind. I'm going to cut the beta release and I wanted to include this PR.

@0nko 0nko merged commit 8010d09 into develop Oct 16, 2019
@0nko 0nko deleted the issue/1402-cache-jetpack-user-email branch October 16, 2019 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Woo: Add jetpack user email param to the wp.getOptions endpoint

2 participants