Just came by to mention that the unit tests and ktlint were failing but it looks like you fixed them 👍

Nice Kotlinification, this much improves the class 🎉.

Other than lint/tests and Oguz's notes this looks good. One thing is that the checkstyle plugin is unhappy with this file and riddles it with newline warnings in the IDE (the actual gradle task passes). Are you seeing that too?

Also for testing, I was wondering @0nko @oguzkocer if you've tried running a migration? Something like:

1. Run really old build of WPAndroid and WooAndroid
2. Login, fetch some posts, etc
3. Build current version of each app using this PR's FluxC hash
4. Run app, check the log for long series of migrations as expected
5. Make sure everything still works

It's probably fine but let's be extra cautious with our migration scripts. I'll try to try this today, if not it'll be next week.

@aforcier I think that's a good idea. I hope the old builds will work fine with the new hash, I know it should, but with Gradle it's not always the case.

@0nko I see some new commits, can you let me know when it's ready for another pass/test?

@aforcier I think that's a good idea. I hope the old builds will work fine with the new hash, I know it should, but with Gradle it's not always the case.

Right - my suggestion was to use old releases, that way they're already compiled and we don't have to worry about being able to build them. Downside is not debuggable, but that's only an issue if there turns out to be an actual problem 😀 (then we'd need to dig in)

@aforcier @oguzkocer Thanks for the review!

I've spent half a day yesterday trying to make the migration run from version 1 work. I found a point where the WellSqlConfig was just added and made it build: 0nko/fluxc-db-v-1. There were a couple of missing create table scripts but it works fine now. It was a bit tricky, though, because for each I needed a version of the table in a specific point in history.

I also wanted to write a unit test that would run the migration the same way automatically but I haven't figured out how to make it work yet.

I've performed some basic testing and things seem to be working.

@oguzkocer You can go ahead with another pass. If I'm able to make the unit test work, we can add it later.

@aforcier, would you mind taking another look? I think it should be good, but just in case. :)

I tested migrating (to a build using the tip of this branch) from a few older WPAndroid versions and one WooAndroid version:

• WPAndroid 7.0, DB version 4
• WPAndroid 9.6, DB version 25
• WooAndroid 1.1, DB version 48

In all cases the migrations ran and were logged correctly, and drafts/data seemed to be preserved.

There's a small problem though - this currently is a breaking change for WPAndroid (in debug but not in release) and WooAndroid (any build). The breaking classes are WPWellSqlConfig and WooWellSqlConfig. There are two causes:

1. The constructors now require Context and a Context? is being supplied.
2. The second reset() function that accepted a helper: WellTableManager was removed

Ah yes, I saw those breaks as well in WPAndroid, but didn't think it would be big deal. I should have mentioned it though since we want to have PRs ready to be merged when this change is merged to develop. Thanks for bringing it up @aforcier!

Thanks for pointing it out, Alex! I added the original reset method with the helper parameter, which was needed for the downgrades. I've created a PR in each repo, ready for review/merge.

Looks good and so do the counterpart PRs - merging this and leaving the Woo and WP PRs open so you can update the tag before those merge.