Gb/upload captured photo#9085
Merged
marecar3 merged 47 commits intogb/feature_upload_media_filefrom Jan 25, 2019
Merged
Conversation
Pass upload media file callback data
# Conflicts: # libs/gutenberg-mobile
# Conflicts: # libs/gutenberg-mobile
…hoto # Conflicts: # libs/gutenberg-mobile
Contributor
Generated by 🚫 Danger |
…hoto # Conflicts: # libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/GutenbergEditorFragment.java # libs/gutenberg-mobile
mzorz
reviewed
Jan 23, 2019
| return view; | ||
| } | ||
|
|
||
| private void requestCameraandStoragePermissions() { |
Contributor
There was a problem hiding this comment.
There's a typo here, should be requestCameraAndStoragePermissions
mzorz
reviewed
Jan 23, 2019
|
|
||
| private static boolean mIsToolbarExpanded = false; | ||
|
|
||
| private static final String[] sPermissions = new String[]{Manifest.permission.CAMERA, |
Contributor
There was a problem hiding this comment.
Let's rename this variable here to something more descriptive like sCameraAndExternalStoragePermissions
mzorz
reviewed
Jan 23, 2019
|
|
||
| @Override | ||
| public void onCapturePhotoButtonClicked() { | ||
| if (!hasPermissions(sPermissions)) { |
Contributor
There was a problem hiding this comment.
Just looking into our codebase, - we can get rid of this private method hasPermissions and requestCameraandStoragePermissions() entirely and use the method checkAndRequestCameraAndStoragePermissions() from our PermissionUtils class, here.
Contributor
There was a problem hiding this comment.
…hoto # Conflicts: # libs/gutenberg-mobile
# Conflicts: # libs/gutenberg-mobile
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java # libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/EditorFragmentAbstract.java # libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/GutenbergEditorFragment.java # libs/gutenberg-mobile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description :
This PR introduces upload of captured image from camera through Gutenberg Editor which implementation is based on this issue.
Following PR's :
gutenberg-mobile
gutenberg