Rnmobile/upload captured photo#13450
Merged
marecar3 merged 7 commits intornmobile/upload_media_filefrom Jan 25, 2019
Merged
Conversation
Contributor
|
@marecar3 Do you mind merging the latest from rnmobile/upload_media_file to this PR? Just to make sure everything is in sync with the changes I did. |
SergioEstevao
approved these changes
Jan 24, 2019
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
I went ahead and merge the latest version of the target branch on this. Everything is working ok so I will give it the 
.
I will just add a small note here for us to consider to merge the three media calls to the bridge in a single call with a type argument: .device, .mediaLibrary, .camera.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the supporting PR for upload of captured image from camera through Gutenberg Editor