Merged
Conversation
Contributor
|
Thank you @theck13 ! LGTM |
ParaskP7
added a commit
that referenced
this pull request
Oct 7, 2022
Warning Message: "'AVATAR' is deprecated. Use AVATAR_WITH_BACKGROUND or AVATAR_WITHOUT_BACKGROUND instead." It is still unclear whether it is safe to replace 'AVATAR' with 'AVATAR_WITH_BACKGROUND', see it being suggested by the 'replaceWith' deprecated annotation field. As such, there deprecated warnings are suppressed, that is, instead of being resolved, since a resolution would require a proper investigation. For more info see: - Issue/deprecate avatar type #8468 (Introduced In): #8468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Deprecate the
AVATARimage type and update instances of it with eitherAVATAR_WITH_BACKGROUNDorAVATAR_WITHOUT_BACKGROUNDbased on the usage. TheAVATARimage type uses an old resource,ic_placeholder_gravatar_grey_lighten_20_100dp, as the error and placeholder image. TheAVATAR_WITH_BACKGROUNDimage type usesbg_oval_grey_user_32dp, which is the avatar design for the Revisions. TheAVATAR_WITHOUT_BACKGROUNDimage type usesic_user_circle_grey_24dp, which is the avatar design for the Me tab and Login epilogue.Instances of
AVATARin the Reader were left as is since it uses a square image for blavatars (e.g.ic_placeholder_blavatar_grey_lighten_20_40dp), which is similar to the oldic_placeholder_gravatar_grey_lighten_20_100dpresource.Test