Rename blog Ids in the blog model, to clear up what they should be used ...#623
Merged
Rename blog Ids in the blog model, to clear up what they should be used ...#623
Conversation
… new naming conventions. I noticed that the remoteBlogId was being passed to CommentDetailFragment, which didn’t seem necessary so I made a few changes to use the localTableBlogId instead.
Contributor
|
@roundhill I updated CommentDetailFragment to clarify where a local vs. remove blog id was being used. If you're ok with those changes, let me know and I'll do the merge. |
Contributor
Author
|
@nbradbury looks good! |
nbradbury
added a commit
that referenced
this pull request
Jan 3, 2014
Rename blog Ids in the blog model, to clear up what they should be used ...
nbradbury
added a commit
that referenced
this pull request
Jan 3, 2014
nbradbury
added a commit
that referenced
this pull request
Jan 3, 2014
|
Nice++ . Needed this for a feature I am adding for review ... thanks! |
nbradbury
added a commit
that referenced
this pull request
Jan 13, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...for. Refs #607.
Blog.id becomes Blog.localTableBlogId.
Blog.blogId becomes Blog.remoteBlogId.