Skip to content

Issue/363 commenting over simplified#523

Merged
maxme merged 11 commits intodevelopfrom
issue/363-commenting-over-simplified
Dec 18, 2013
Merged

Issue/363 commenting over simplified#523
maxme merged 11 commits intodevelopfrom
issue/363-commenting-over-simplified

Conversation

@nbradbury
Copy link
Copy Markdown
Contributor

Added the ability to un-approve a comment and mark it as spam, which fixes #363

Also fixes #512

@ghost ghost assigned maxme Dec 18, 2013
@maxme
Copy link
Copy Markdown
Contributor

maxme commented Dec 18, 2013

Case when we shouldn't display approve/spam buttons:

  1. Signin on your device with user A
  2. Post a comment with user A on a blog post X (blog that user A doesn't own)
  3. User B reply to user A previous comment
  4. A notification is sent to the device where user A is signed in: "User B replied"
  5. Approve / Spam buttons shouldn't be visible (you don't own that blog)
  6. Bonus: reply to this comment fails

…tification - handles notifications for replies to comments made on someone else's blog. Also determining which actions (moderate / spam / reply) to enable based on the actions returned by the notification.
@nbradbury
Copy link
Copy Markdown
Contributor Author

Maxime, that last commit should fix those problems.

@maxme
Copy link
Copy Markdown
Contributor

maxme commented Dec 18, 2013

This patch fixes previous issues. We could remove the "Approved" mention for comments made on someone else's blog.
screen shot 2013-12-18 at 16 17 28

@maxme
Copy link
Copy Markdown
Contributor

maxme commented Dec 18, 2013

Tested, fixes #363 #512

maxme added a commit that referenced this pull request Dec 18, 2013
…er-simplified

Issue/363 commenting over simplified
@maxme maxme merged commit 23563f6 into develop Dec 18, 2013
@maxme maxme deleted the issue/363-commenting-over-simplified branch December 18, 2013 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Named links aren't tappable in comment detail Comment unification over-simplfied moderation

2 participants