Issue/3855 plans not serializable#3857
Merged
daniloercoli merged 2 commits intodevelopfrom Mar 14, 2016
Merged
Conversation
Contributor
|
This is probably going to be changed soon, since the new version (1.3) of the |
daniloercoli
added a commit
that referenced
this pull request
Mar 14, 2016
…erializable Issue/3855 plans not serializable
Contributor
Author
💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3855
To test: Open plans, then background the app. Prior to this fix, the app would crash with a
NotSerializableException.The problem was caused by serializing the Plan object (
mPlanDetails) when saving the fragment state because the Plan contains a "PlanFeaturesHighlightSection" object which didn't implementSerializable.Rather than resolve this by implementing
Serializablein PlanFeaturesHighlightSection, I chose to stop serializing the Plan object. When the SitePlan is restored, it takes care of loading the correct plan. I decided this was a safer approach due to the downsides of serializing (namely, it leads to issue like this one!).Needs review: @daniloercoli