Skip to content

Issue/2977 add media settings back#3566

Merged
kwonye merged 9 commits intofeature/site-settings-reviewfrom
issue/2977-add-media-settings-back
Jan 7, 2016
Merged

Issue/2977 add media settings back#3566
kwonye merged 9 commits intofeature/site-settings-reviewfrom
issue/2977-add-media-settings-back

Conversation

@tonyr59h
Copy link
Copy Markdown
Contributor

@tonyr59h tonyr59h commented Jan 6, 2016

This PR introduces a new category, This Device, which groups device-specific settings. Enable Location is the only Calypso setting that is device specific. Two settings that were in the old settings screen, Default Image Width and Upload and link to full image, are also added under the new category.

cc @kwonye (last issue!), @mattmiklic (design verification)

@tonyr59h tonyr59h added this to the 5.0 milestone Jan 6, 2016
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niicceee cc: @nbradbury :)

@kwonye
Copy link
Copy Markdown
Contributor

kwonye commented Jan 7, 2016

Noticed that blog_preferences.xml still contains CheckBoxs, can we change them to WPCheckBox please?

Once all comments are addressed and design is 👌 with @mattmiklic, feel free to :shipit:

Great work!

@mattmiklic
Copy link
Copy Markdown
Member

Everything looks just fine visually. 👌

I ran into a bug; I noticed that the first time the settings screen loads for a particular blog, I get a "The username or password you entered is incorrect" error. It doesn't appear on subsequent loads of the settings page for that site. If I switch to a different site, I'll get the same error the first time it loads. This is all on a fresh install of this branch with my WP.com credentials (which are obviously correct, since it was able to load my sites and their settings).

screenshot_20160106-235850

@kwonye
Copy link
Copy Markdown
Contributor

kwonye commented Jan 7, 2016

By goodness @mattmiklic, you have a system update!!!

Just FYI I didn't get that error

@tonyr59h
Copy link
Copy Markdown
Contributor Author

tonyr59h commented Jan 7, 2016

I ran into a bug

Resolved in 3aefb83

@kwonye
Copy link
Copy Markdown
Contributor

kwonye commented Jan 7, 2016

Verified repro steps from @tonyr59h for that bug

New account with no account cached. Resolved in 3aefb83

kwonye added a commit that referenced this pull request Jan 7, 2016
…ettings-back

Issue/2977 add media settings back
@kwonye kwonye merged commit 3e33a48 into feature/site-settings-review Jan 7, 2016
@kwonye kwonye deleted the issue/2977-add-media-settings-back branch January 7, 2016 05:23
@kwonye
Copy link
Copy Markdown
Contributor

kwonye commented Jan 7, 2016

Addresses #2977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants