Writing settings by tonyr59h · Pull Request #3243 · wordpress-mobile/WordPress-Android

tonyr59h · 2015-09-25T03:47:06Z

Self-hosted sites have an API limitation with the default post category and format. Because of this those are stored locally as preferences. WP.com sites work as expected.

What's in this PR:

Location setting saved/restored, used in post editor
Username/password for self-hosted sites only
Default post category, not saved remotely on self-hosted
Default post format, not saved remotely on self-hosted
Related Posts with previews, .com only

To test, change each of the following on both self-hosted and .com sites. Be sure to test test app-web changes and web->app changes for both:

Title
Tagline
Language
Location
Default Category
Default Format
Related Posts

…-settings Conflicts: WordPress/src/main/res/values/strings.xml

…-settings

…alues, and loading cached settings on a background thread.

…-settings

… race conditions.

…-settings

kwonye · 2015-10-29T15:45:25Z

On initial loading of settings on a site, the Default Category/Default Format do not show up (sometimes both, sometimes just one). I have to click the cell and select it for it to show up.

…-settings

tonyr59h · 2015-10-30T04:05:11Z

All fixed up 👍

kwonye · 2015-10-30T19:09:51Z

Still having issues of Default Category/Default Format not showing up everytime I open settings.
Also, Default Category has a default_category option that I don't think belongs there.
And Default Format doesn't auto-select to Standard.
Standard Format is at the bottom

tonyr59h · 2015-10-30T19:54:33Z

Default Category has a default_category option that I don't think belongs there

Heh, that was an accident during testing. It's definitely a category I added to your site 😛

…-settings

tonyr59h · 2015-11-02T21:42:21Z

Still having issues of Default Category/Default Format not showing up everytime I open settings

Just noticed you were on a self-hosted site. Per conversation with Matt and Sergio we will only be showing default category and post format for WP.com sites.

…-settings

tonyr59h · 2015-11-03T00:28:19Z

Just addressed a few more minor bugs/edge cases. Ready for another review. Note: not going to have a designer sign off on this PR since it won't be merged into develop. I'll ping Matt after discussion settings have been merged into the review branch so everything can be taken care of before merging.

kwonye · 2015-11-03T05:46:32Z

Crash when initial location request happens. Doesn't seem to be in the code you've added, so let me know if you think I should create a separate issue for it.

11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime: FATAL EXCEPTION: main
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime: Process: org.wordpress.android, PID: 22196
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime: java.lang.RuntimeException: Failure delivering result ResultInfo{who=@android:requestPermissions:, request=2, result=-1, data=Intent { act=android.content.pm.action.REQUEST_PERMISSIONS (has extras) }} to activity {org.wordpress.android/org.wordpress.android.ui.posts.EditPostActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setVisibility(int)' on a null object reference
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.ActivityThread.deliverResults(ActivityThread.java:3699)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.ActivityThread.handleSendResult(ActivityThread.java:3742)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.ActivityThread.-wrap16(ActivityThread.java)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1393)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.os.Handler.dispatchMessage(Handler.java:102)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.os.Looper.loop(Looper.java:148)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.ActivityThread.main(ActivityThread.java:5417)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at java.lang.reflect.Method.invoke(Native Method)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:  Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setVisibility(int)' on a null object reference
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at org.wordpress.android.ui.posts.EditPostSettingsFragment.showLocationSearch(EditPostSettingsFragment.java:670)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at org.wordpress.android.ui.posts.EditPostActivity.onRequestPermissionsResult(EditPostActivity.java:432)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.Activity.dispatchRequestPermissionsResult(Activity.java:6553)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.Activity.dispatchActivityResult(Activity.java:6432)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.ActivityThread.deliverResults(ActivityThread.java:3695)
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.ActivityThread.handleSendResult(ActivityThread.java:3742) 
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.ActivityThread.-wrap16(ActivityThread.java) 
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1393) 
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.os.Handler.dispatchMessage(Handler.java:102) 
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.os.Looper.loop(Looper.java:148) 
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at android.app.ActivityThread.main(ActivityThread.java:5417) 
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at java.lang.reflect.Method.invoke(Native Method) 
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726) 
11-02 21:38:05.173 22196-22196/org.wordpress.android E/AndroidRuntime:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

kwonye · 2015-11-03T21:43:23Z

Location post crash addressed

…ettings Writing settings

tonyr59h added 30 commits August 19, 2015 13:05

Adding Writing and Account preferences to UI.

053e659

Merge branch 'feature/site-settings-review' into feature/2887-writing…

c36df63

…-settings Conflicts: WordPress/src/main/res/values/strings.xml

Handling account settings changes on self-hosted sites.

5658eaa

Using location preference to toggle post location capabilities.

90aeab6

Setting up category and format preferences with entries.

4887bd1

Adding settings table to database for caching. De-coupling some logic.

946188b

Janitorial work on SiteSettingsFragment.

b28cb25

Fixing SQL syntax.

41616b7

Storing settings locally and fixing up some save/load logic.

1252e4a

Merge branch 'feature/site-settings-review' into feature/2887-writing…

74ebca0

…-settings

Removing non-existant resource usage.

acac0f6

Using WPSwitchFragment to set custom font on title text for Location

3b8b8cf

Creating table for categories in the site settings database.

b03fa5c

Getting supported post formats.

90dbfe4

Updating preference view with supported post formats.

e66cba0

Merge branch 'feature/site-settings-review' into feature/2887-writing…

a1f9337

…-settings

Adding hints to writing preferences.

3976830

Setting summary for category and format preferences.

e65a7a2

Fixing formatting on preference dialog when there is no detail text.

aa17c43

Moving inline strings to resources.

4c5ed73

SiteSettings implementation now separates self-hosted from .com logic.

cc8fde7

Reworking CategoryModel object responsibilities.

7e60784

Populating post formats and categories preferences, setting initial v…

cb7f0d6

…alues, and loading cached settings on a background thread.

Merge branch 'feature/site-settings-review' into feature/2887-writing…

0332b06

…-settings

Removing legacy SiteSettings class. Caching post formats. Fixing some…

da18345

… race conditions.

Merge branch 'feature/site-settings-review' into feature/2887-writing…

14266d4

…-settings

Using unique XMLRPCClientInterface objects for queries.

ccfda9e

Moving network related work out of the Site Settings data model.

b528c05

Removing SiteSettingsTable dependency from SiteSettingsModel.

12d8fe9

Fixing local-only storage of location preference.

43423d4

tonyr59h added 3 commits October 25, 2015 22:21

Removing commented out code.

cb05dae

Auto-select the first item in if none selected

a41af2d

Adding buttons to dialog, styling, implementing cancel functionality.

5a556b8

maxme modified the milestones: 4.8, 4.7 Oct 28, 2015

tonyr59h added 2 commits October 29, 2015 21:04

Setting default post format to standard

c3f4ce0

Merge branch 'feature/site-settings-review' into feature/2887-writing…

67c3b59

…-settings

tonyr59h assigned kwonye Nov 2, 2015

tonyr59h added 2 commits November 1, 2015 18:52

Merge branch 'feature/site-settings-review' into feature/2887-writing…

ca441ee

…-settings

Removing unusable settings from self-hosted.

25b9eae

tonyr59h added 4 commits November 2, 2015 15:49

Fixing new post geotagging and default format value.

be96667

Merge branch 'feature/site-settings-review' into feature/2887-writing…

53bed7d

…-settings

Fixing cached settings for self-hosted sites

f02ff4a

Related posts not updated when user cancels

caa1214

tonyr59h added 2 commits November 2, 2015 22:06

Verifying state of fragment before modifying views

ce1767d

Defer location permission check until after view references are set

ca7ecf5

kwonye added a commit that referenced this pull request Nov 3, 2015

Merge pull request #3243 from wordpress-mobile/feature/2887-writing-s…

364ecfd

…ettings Writing settings

kwonye merged commit 364ecfd into feature/site-settings-review Nov 3, 2015

kwonye deleted the feature/2887-writing-settings branch November 3, 2015 21:43

tonyr59h mentioned this pull request Nov 3, 2015

Writing Site Settings #2887

Closed

kwonye restored the feature/2887-writing-settings branch November 4, 2015 23:22

kwonye deleted the feature/2887-writing-settings branch November 4, 2015 23:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Writing settings#3243

Writing settings#3243
kwonye merged 75 commits intofeature/site-settings-reviewfrom
feature/2887-writing-settings

tonyr59h commented Sep 25, 2015

Uh oh!

kwonye commented Oct 29, 2015

Uh oh!

tonyr59h commented Oct 30, 2015

Uh oh!

kwonye commented Oct 30, 2015

Uh oh!

tonyr59h commented Oct 30, 2015

Uh oh!

tonyr59h commented Nov 2, 2015

Uh oh!

tonyr59h commented Nov 3, 2015

Uh oh!

kwonye commented Nov 3, 2015

Uh oh!

kwonye commented Nov 3, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tonyr59h commented Sep 25, 2015

Uh oh!

kwonye commented Oct 29, 2015

Uh oh!

tonyr59h commented Oct 30, 2015

Uh oh!

kwonye commented Oct 30, 2015

Uh oh!

tonyr59h commented Oct 30, 2015

Uh oh!

tonyr59h commented Nov 2, 2015

Uh oh!

tonyr59h commented Nov 3, 2015

Uh oh!

kwonye commented Nov 3, 2015

Uh oh!

kwonye commented Nov 3, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants