Merged
Conversation
…in <strong>..</strong> at runtime to match username in note_block_user_header
Contributor
|
In the reference screen shot, comment text ("Nice! Not sure if...") is not italicized, should we remove italics there? |
Contributor
|
Fill a new issue to add color handling in |
Contributor
Author
|
@drw158 See Maxime's comment above - Android has the text of the reply in italics, but your screenshot of the web notification doesn't use italics. Should we remove italics as part of this PR? |
Contributor
|
Yes please remove the italics there, thanks for the catch! |
Contributor
Author
|
@maxme ready for another look. |
Contributor
|
|
maxme
added a commit
that referenced
this pull request
Feb 27, 2015
…ly-header Issue/notification reply header
Contributor
|
Thanks for tackling this one @nbradbury! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described here. Note that the color of the post title is not changed yet - that will come later.
Before and after shot below: