Conversation
Generated by 🚫 Danger |
WordPress/src/main/java/org/wordpress/android/ui/photopicker/PhotoPickerViewModel.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Outdated
Show resolved
Hide resolved
...ss/android/ui/posts/prepublishing/categories/addcategory/PrepublishingAddCategoryFragment.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/viewmodel/main/WPMainActivityViewModel.kt
Outdated
Show resolved
Hide resolved
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20016-0bd3e14 | |
| Commit | 0bd3e14 | |
| Direct Download | wordpress-prototype-build-pr20016-0bd3e14.apk |
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20016-0bd3e14 | |
| Commit | 0bd3e14 | |
| Direct Download | jetpack-prototype-build-pr20016-0bd3e14.apk |
Generated by 🚫 dangerJS |
.../editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergContainerFragment.java
Outdated
Show resolved
Hide resolved
# Conflicts: # WordPress/build.gradle # WordPress/src/main/java/org/wordpress/android/ui/jetpackoverlay/JetpackFeatureRemovalPhaseHelper.kt # WordPress/src/main/java/org/wordpress/android/ui/main/WPMainActivity.java # WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java # WordPress/src/main/java/org/wordpress/android/ui/stories/StoryComposerActivity.kt # WordPress/src/main/java/org/wordpress/android/ui/stories/media/StoryEditorMedia.kt # WordPress/src/main/java/org/wordpress/android/ui/stories/media/StoryMediaSaveUploadBridge.kt # WordPress/src/main/java/org/wordpress/android/util/SiteUtils.java # WordPress/src/main/res/values-gl/strings.xml # WordPress/src/main/res/values-lv/strings.xml # build.gradle
|
Found 1 violations: The PR caused some dependency changes (expand to see details)
++--- androidx.lifecycle:lifecycle-livedata-ktx:2.6.2
+| +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (*)
+| +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
+| +--- androidx.lifecycle:lifecycle-common:2.6.2 (c)
+| +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c)
+| +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c)
+| +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (c)
+| +--- androidx.lifecycle:lifecycle-process:2.6.2 (c)
+| +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c)
+| +--- androidx.lifecycle:lifecycle-runtime-ktx:2.6.2 (c)
+| +--- androidx.lifecycle:lifecycle-service:2.6.2 (c)
+| +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c)
+| +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.2 (c)
+| +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 (c)
+| +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c)
+| \--- androidx.lifecycle:lifecycle-common-java8:2.6.2 (c)
++--- androidx.camera:camera-camera2:1.2.3
+| +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+| +--- androidx.camera:camera-core:1.2.3
+| | +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+| | +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
+| | +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
+| | +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
+| | +--- androidx.exifinterface:exifinterface:1.3.2 -> 1.3.6 (*)
+| | +--- androidx.lifecycle:lifecycle-common:2.1.0 -> 2.6.2 (*)
+| | +--- androidx.lifecycle:lifecycle-livedata:2.1.0 -> 2.6.2 (*)
+| | +--- com.google.auto.value:auto-value-annotations:1.6.3
+| | +--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.20 (*)
+| +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
+| +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
+| +--- com.google.auto.value:auto-value-annotations:1.6.3
+| \--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
-+--- com.automattic:stories:2.4.0
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.9.10 (*)
-| +--- androidx.databinding:viewbinding:8.1.0 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-serialization-runtime:1.0-M1-1.4.0-rc
-| | \--- org.jetbrains.kotlinx:kotlinx-serialization-runtime-jvm:1.0-M1-1.4.0-rc
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.0-rc -> 1.9.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.0-rc -> 1.9.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-reflect:1.6.10
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.20 (*)
-| +--- androidx.appcompat:appcompat:1.0.2 -> 1.6.1 (*)
-| +--- androidx.constraintlayout:constraintlayout:1.1.3 -> 2.1.4 (*)
-| +--- androidx.core:core-ktx:1.2.0 -> 1.12.0 (*)
-| +--- androidx.emoji:emoji:1.0.0
-| | \--- androidx.core:core:1.0.0 -> 1.12.0 (*)
-| +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-| +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
-| +--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
-| +--- jp.wasabeef:glide-transformations:4.3.0
-| | \--- com.github.bumptech.glide:glide:4.11.0 -> 4.16.0 (*)
-| +--- org.greenrobot:eventbus:3.3.1 (*)
-| +--- com.automattic.stories:photoeditor:2.4.0
-| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-| | +--- org.jetbrains.kotlinx:kotlinx-serialization-runtime:1.0-M1-1.4.0-rc (*)
-| | +--- androidx.appcompat:appcompat:1.0.2 -> 1.6.1 (*)
-| | +--- androidx.core:core-ktx:1.2.0 -> 1.12.0 (*)
-| | +--- androidx.camera:camera-core:1.0.0-alpha06 -> 1.2.3
-| | | +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-| | | +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
-| | | +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
-| | | +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
-| | | +--- androidx.exifinterface:exifinterface:1.3.2 -> 1.3.6 (*)
-| | | +--- androidx.lifecycle:lifecycle-common:2.1.0 -> 2.6.2 (*)
-| | | +--- androidx.lifecycle:lifecycle-livedata:2.1.0 -> 2.6.2 (*)
-| | | +--- com.google.auto.value:auto-value-annotations:1.6.3
-| | | +--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.20 (*)
-| | +--- androidx.camera:camera-camera2:1.0.0-alpha06 -> 1.2.3
-| | | +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-| | | +--- androidx.camera:camera-core:1.2.3 (*)
-| | | +--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*)
-| | | +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
-| | | +--- com.google.auto.value:auto-value-annotations:1.6.3
-| | | \--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
-| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
-| | +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
-| | +--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
-| | +--- jp.wasabeef:glide-transformations:4.3.0 (*)
-| | +--- com.github.chrisbanes:PhotoView:2.3.0
-| | | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
-| | +--- com.automattic.stories:mp4compose:2.4.0
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-| | | \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
-| | \--- androidx.emoji:emoji:1.0.0 (*)
-| +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.6.2 (*)
-| +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.2.0 -> 2.6.2 (*)
-| +--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0 -> 2.6.2
-| | +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (*)
-| | +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (*)
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 -> 1.9.20 (*)
-| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 -> 1.7.3 (*)
-| | +--- androidx.lifecycle:lifecycle-common:2.6.2 (c)
-| | +--- androidx.lifecycle:lifecycle-common-java8:2.6.2 (c)
-| | +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c)
-| | +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c)
-| | +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.6.2 (c)
-| | +--- androidx.lifecycle:lifecycle-process:2.6.2 (c)
-| | +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c)
-| | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.6.2 (c)
-| | +--- androidx.lifecycle:lifecycle-service:2.6.2 (c)
-| | +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c)
-| | +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.2 (c)
-| | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.2 (c)
-| | \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
-| \--- com.github.chrisbanes:PhotoView:2.3.0 (*)
-+--- com.automattic.stories:mp4compose:2.4.0 (*)
-+--- androidx.lifecycle:lifecycle-livedata-ktx:2.6.2 (*)
-+--- androidx.camera:camera-camera2:1.2.3 (*)
-\--- com.github.chrisbanes:PhotoView:2.3.0 (*)
+\--- com.github.chrisbanes:PhotoView:2.3.0
+ \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
Please review and act accordingly
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20016 +/- ##
==========================================
+ Coverage 40.17% 40.39% +0.21%
==========================================
Files 1476 1459 -17
Lines 68248 67161 -1087
Branches 11331 11146 -185
==========================================
- Hits 27418 27129 -289
+ Misses 38320 37550 -770
+ Partials 2510 2482 -28 ☔ View full report in Codecov by Sentry. |
|
Thank you for cleaning up the code @jarvislin 🙇 |
antonis
left a comment
There was a problem hiding this comment.
I plan to take a 2nd pass tomorrow or Monday since the changes are extensive and I might have missed something.
I made another pass today and I have noticed any issues on the code or comparing the functionality with a build from trunk 🎉
I would suggest removing the unneeded string resource changes #20016 (comment), adding the missing icons you detected (though unrelated with this PR) and proceeding with a merge.
…-extra Stories Additional Code Removals
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/prefs/AppPrefs.java # WordPress/src/main/java/org/wordpress/android/ui/prefs/AppPrefsWrapper.kt # WordPress/src/main/res/values-gl/strings.xml
|
@antonis Thank you so much for reviewing this PR. |
antonis
left a comment
There was a problem hiding this comment.
Awesome work @jarvislin 🏅
The code changes look consistent to me and the app behaved as expected in my tests. I've tested both the Jetpack app and the WordPress app for any side effects and didn't notice any issues.
It feels great cleaning up the code (6.3K loc 😮) along with the feature :)
I am so happy for this. I've finally completed my onboarding project 🥹 |


See: p1706056464986299/1705928714.429819-slack-C0436E5L5V1
This is a follow-up PR for #20014 which removes Stories from the codebase.
To Test:
Please smoke test following areas:
The behavior should be the same as the trunk branch.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.UI Changes Testing Checklist: