Skip to content

Disable the Stories feature#20014

Merged
antonis merged 3 commits intorelease/24.1from
issue/disable-stories-flag
Jan 24, 2024
Merged

Disable the Stories feature#20014
antonis merged 3 commits intorelease/24.1from
issue/disable-stories-flag

Conversation

@jarvislin
Copy link
Copy Markdown
Contributor

@jarvislin jarvislin commented Jan 24, 2024

See: p1706056464986299/1705928714.429819-slack-C0436E5L5V1

We want to disable the Stories feature, this PR simply turns off the flag. There will be a follow-up PR for removing the feature from our codebase.

To Test:

  1. Sign in the JP app.
  2. Click on the FAB.
  3. It should not display the Story post option.
  4. Click on Blog post in the FAB options.
  5. Click on the ＋ icon at the left-bottom corner to open the Search blocks full-screen bottom sheet.
  6. Search story
  7. The Story block should not be found in the search result.
  8. Done!

Regression Notes

  1. Potential unintended areas of impact

    • None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual

  3. What automated tests I added (or what prevented me from doing so)

    • None

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@jarvislin jarvislin added this to the 24.1 ❄️ milestone Jan 24, 2024
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 24, 2024 •
edited
Loading

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone
⚠️

This PR contains changes to RELEASE_NOTES.txt.
Note that these changes won't affect the final version of the release notes as this version is in code freeze.
Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 dangerJS

@dangermattic
Copy link
Copy Markdown
Collaborator

dangermattic commented Jan 24, 2024 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 24.1 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jan 24, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20014-27123ce
Commit27123ce
Direct Downloadwordpress-prototype-build-pr20014-27123ce.apk
 Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jan 24, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20014-27123ce
Commit27123ce
Direct Downloadjetpack-prototype-build-pr20014-27123ce.apk
 Note: Google Login is not supported on these builds.

@jarvislin jarvislin requested a review from antonis January 24, 2024 04:39
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2cae7c0) 40.42% compared to head (27123ce) 40.42%.

Files Patch % Lines
...jetpackoverlay/JetpackFeatureRemovalPhaseHelper.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           release/24.1   #20014   +/-   ##
=============================================
  Coverage         40.42%   40.42%           
=============================================
  Files              1443     1443           
  Lines             66567    66564    -3     
  Branches          10974    10972    -2     
=============================================
  Hits              26910    26910           
+ Misses            37170    37167    -3     
  Partials           2487     2487

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

antonis
antonis approved these changes Jan 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@antonis antonis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this Jarvis 🙇
LGTM and works as expected 🎉

@antonis antonis merged commit f0fe060 into release/24.1 Jan 24, 2024
@antonis antonis deleted the issue/disable-stories-flag branch January 24, 2024 07:51
@jarvislin jarvislin mentioned this pull request Jan 24, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@antonis antonis antonis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Task

Projects

None yet

Milestone

24.1

Development

Successfully merging this pull request may close these issues.

4 participants

@jarvislin @dangermattic @wpmobilebot @antonis