Part-3: Compiler Warnings as Errors - WordPress Module - FragmentManager#19568
Conversation
Note: This fragment is mostly unused right now.
1) Usual changes 2) Removed unused show(T parentActivity) function as we want to encourage the use of childFragmentManager for DialogFragments.
1) Usual Fixes. 2) Replaced getSupportFragmentManager with getChildFragmentManager where Dialogs are used.
Since TextInputDialogFragment was used MyProfileFragment, it was also updated. Updations (Removal of usage of TargetFragment) to TextInputDialogFragment led to updation of its usage in MySiteFragment.
1) Usual changes. 2) Refactored deprecated usage of optionsCreateMenu with menuProvider.
|
@antonis PR ready for review. |
|
Thank you for your contribution @07jasjeet 🙇
Heads up that I plan to review this PR on the week starting on November 20th since I will be out of office next week. |
There was a problem hiding this comment.
Awesome work @07jasjeet 🏅
The code changes look good and the app behaved as expected in my tests 🎉
Thank you also for providing detailed test instructions 🙇
ImageSettingsDialogFragment.java:
This dialog isn't being used anywhere as of now.
Good catch 👍 I think this can be safely removed. This can be part of a separate PR though to be investigated and tested properly.
Thanks again for contributing to WordPress-Android 🙇♂️
Heads up that I've opened a PR for this #19658 |
Fixes #17253 partially. (Sub-ticket of #17246)
To test:
RoleSelectDialogFragment.java:
EditPostSettingsFragment.java:
MyProfileFragment.java:
SiteSettingsTagListActivity.java + SiteSettingsTagDetailFragment:
SiteSettingsFragment.java:
No changes here as migrating to AndroidX Preference is the only way to migrate from getFragmentManager. This issue dictates the progress of the problem I just mentioned. So, for now, this file will remain as is.
ImageSettingsDialogFragment.java:
MySiteFragment's onCreate.Regression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual Testing
What automated tests I added (or what prevented me from doing so)
None
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: