Skip to content

Removes ImageSettingsDialogFragment which is not used anymore#19658

Merged
antonis merged 2 commits intotrunkfrom
task/remove-ImageSettingsDialogFragment
Nov 28, 2023
Merged

Removes ImageSettingsDialogFragment which is not used anymore#19658
antonis merged 2 commits intotrunkfrom
task/remove-ImageSettingsDialogFragment

Conversation

@antonis
Copy link
Copy Markdown
Contributor

@antonis antonis commented Nov 23, 2023

Description

This PR removes ImageSettingsDialogFragment which is not used anymore as identified in #19568 (review)


To Test:

  • Verify that the app builds and the CI checks pass
  • Verify that the editor opens and behaves as expected

Regression Notes

  1. Potential unintended areas of impact

Editor

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

  1. What automated tests I added (or what prevented me from doing so)

N/A since this PR involves code cleanup


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@antonis antonis added [Type] Task Gutenberg Editing and display of Gutenberg blocks. Tech Debt labels Nov 23, 2023
@antonis antonis marked this pull request as ready for review November 23, 2023 14:57
@antonis antonis requested review from justtwago and mkevins November 23, 2023 15:01
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Nov 23, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19658-e7938b7
Commite7938b7
Direct Downloadjetpack-prototype-build-pr19658-e7938b7.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Nov 23, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19658-e7938b7
Commite7938b7
Direct Downloadwordpress-prototype-build-pr19658-e7938b7.apk
Note: Google Login is not supported on these builds.

@antonis antonis marked this pull request as draft November 23, 2023 16:16
@antonis
Copy link
Copy Markdown
Contributor Author

antonis commented Nov 23, 2023

Converting to draft to figure out the CI failures

@peril-wordpress-mobile
Copy link
Copy Markdown

Warnings
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Copy Markdown
Contributor

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@antonis
Copy link
Copy Markdown
Contributor Author

antonis commented Nov 23, 2023

Converting to draft to figure out the CI failures

Removed some extra unused resources with e7938b7 :)

@antonis antonis marked this pull request as ready for review November 23, 2023 17:25
@antonis antonis added this to the 23.9 milestone Nov 23, 2023
Copy link
Copy Markdown
Contributor

@justtwago justtwago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code removal! Tested the editor and it seems to work as usual 👌

@antonis
Copy link
Copy Markdown
Contributor Author

antonis commented Nov 28, 2023

Thank you for reviewing Artyom 🙇

@antonis antonis merged commit f0c44ca into trunk Nov 28, 2023
@antonis antonis deleted the task/remove-ImageSettingsDialogFragment branch November 28, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks. Tech Debt [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants