Skip to content

fix #141 drawable cleanup and update#1924

Merged
nbradbury merged 44 commits intodevelopfrom
issue/141-drawable-cleanup-and-update
Oct 9, 2014
Merged

fix #141 drawable cleanup and update#1924
nbradbury merged 44 commits intodevelopfrom
issue/141-drawable-cleanup-and-update

Conversation

@maxme
Copy link
Copy Markdown
Contributor

@maxme maxme commented Oct 9, 2014

fix #141 drawable cleanup and update.

  • Remove drawable-mdpi and drawable-ldpi folders
  • Add all xxhdpi missing icons and images, except nine patches.
  • Remove unused drawables (xxxhdpi)
  • Try to keep a consisent naming

Next step would be to rename other drawables to follow the same naming convention.

maxme added 30 commits September 30, 2014 11:52
@maxme
remove mdpi and ldpi icons and unused xxxhdpi
4831c54
@maxme
chmod all drawable files to 644
335cc2d
@maxme
about screen redesign
ac248de
@maxme
new 150px/200px/300px mystery man
329756d
@maxme
remove unused drawables
ea68993
@maxme
remove mdpi check from tools/check-missing-drawables.py
7b1344d
@maxme
fix px/dpi ratio for drawable-hpdi/ic_level_indicator.png
3dce5ed
@maxme
replace ab_icon_new.png by ic_action_new.png and add it to xxhdpi/
762cadc
@maxme
replace ab_icon_refresh.png by ic_action_refresh.png and add it to xx…
b884483 
…hdpi/
@maxme
replace ab_icon_reply.png by ic_action_reply.png and add it to xxhdpi/
c5e3171
@maxme
replace ab_icon_save.png by ic_action_save.png and add it to xxhdpi/
5203976
@maxme
replace ab_icon_send.png by ic_action_send_now.png and add it to xxhdpi/
94ff170
@maxme
replace ab_icon_send.png by ic_action_send_now_dark.png and add it to…
87b447b 
… xxhdpi/
@maxme
replace ab_icon_share.png by ic_action_share.png and add it to xxhdpi/
1df5c77
@maxme
replace ab_icon_web.png by ic_action_web_site.png and add it to xxhdpi/
7718bec
@maxme
replace ab_icon_wp.png by dashicon_wordpress_alt.png and add it to xx…
802d0c6 
…hdpi/
@maxme
Merge branch 'develop' into issue/141-drawable-cleanup-and-update
942073b
@maxme
replace dashboard_icon_comments.png by dashicon_admin_comments_black.…
3d602c8 
…png and add it to xxhdpi/
@maxme
replace dashboard_icon_notifications.png by noticon_notification_blac…
f491259 
…k.png and add it to xxhdpi/
@maxme
replace dashboard_icon_pages.png by dashicon_admin_page_black.png and…
e466082 
… add it to xxhdpi/
@maxme
replace dashboard_icon_photo.png by dashicon_camera.png and add it to…
1cfd9e0 
… xxhdpi/
@maxme
replace dashboard_icon_video.png by dashicon_video_alt2.png and add i…
81cef54 
…t to xxhdpi/
@maxme
postfix dashicon_camera and dashicon_video_alt2 with _black
1d3b138
@maxme
replace dashboard_icon_media.png by dashicon_admin_media_black.png an…
ac4dd27 
…d add it to xxhdpi/
@maxme
replace dashboard_icon_posts.png by dashicon_admin_post_black.png and…
6a6c0ce 
… add it to xxhdpi/
@maxme
replace dashboard_icon_stats.png by dashicon_chart_area_black.png and…
b84ce33 
… add it to xxhdpi/
@maxme
replace dashboard_icon_subs.png by noticon_reader_alt_black.png and a…
fb642e3 
…dd it to xxhdpi/
@maxme
replace dashboard_icon_view.png by noticon_show_black.png and add it …
258cd1a 
…to xxhdpi/
@maxme
replace dashboard_icon_wp.png by dashicon_external_black.png and add …
8c621c4 
…it to xxhdpi/
@maxme
replace notification_multi.png by noticon_notification.png and add it…
816d47d 
… to xxhdpi/
maxme added 12 commits October 7, 2014 17:22
@maxme
replace tab_icon_checkmark.png by ic_action_accept.png and add it to …
592a3fc 
…xxhdpi/
@maxme
replace tab_icon_search.png by ic_action_search.png and add it to xxh…
11cc9e3 
…dpi/ and xhdpi/
@maxme
replace tab_icon_trash.png by ic_action_discard.png and add it to xxh…
3a5edc6 
…dpi/
@maxme
replace ic_drawer.png by ic_navigation_drawer.png and add it to xxhdpi/
f5fd658
@maxme
replace nux_icon_alert.png by noticon_alert_big.png and add it to xxh…
5142b56 
…dpi/
@maxme
Merge branch 'develop' into issue/141-drawable-cleanup-and-update
04649e5
@maxme
replace icon_format_bold*.png by dashicon_editor_bold*.png and add it…
d6e7fbd 
… to xxhdpi/ and remove padding from image
@maxme
replace all format buttons drawables
9072e39
@maxme
chmod 644 all drawables
ddf6abf
@maxme
replace ic_comment_like(_active).png by noticon_star_(un)active.png a…
2db7e1d 
…nd add it to xxhdpi/ and xhdpi/
@maxme
replace remote_(image/failed).png by dashicon_format_image_big_grey.p…
0607c7e 
…ng and noticon_warning_big_grey.png and add them to xxhdpi/ and xhdpi/
@maxme
remove duplicated ic_cab_trash
d4de01a
@maxme maxme added this to the 3.4 milestone Oct 9, 2014
@nbradbury nbradbury self-assigned this Oct 9, 2014
@nbradbury
Copy link
Copy Markdown
Contributor

nbradbury commented Oct 9, 2014

Lint still shows a number of unused drawables.

screen shot 2014-10-09 at 5 31 56 am

@maxme
Copy link
Copy Markdown
Contributor Author

maxme commented Oct 9, 2014

Lint still shows a number of unused drawables.

fixed in 0112e78

This typo ImageViewh causes the app to crash when the About screen is shown.

fixed in 871ac9e

@nbradbury
Copy link
Copy Markdown
Contributor

nbradbury commented Oct 9, 2014

:shipit:

nbradbury added a commit that referenced this pull request Oct 9, 2014
@nbradbury
Merge pull request #1924 from wordpress-mobile/issue/141-drawable-cle…
46cb683 
…anup-and-update

fix #141 drawable cleanup and update
@nbradbury nbradbury merged commit 46cb683 into develop Oct 9, 2014
@nbradbury nbradbury deleted the issue/141-drawable-cleanup-and-update branch October 9, 2014 14:25
roundhill added a commit that referenced this pull request Oct 21, 2014
@roundhill
Restores the reply icon, accidentally removed in #1924
f68587e 
Fixes #1948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nbradbury nbradbury

Labels

None yet

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

Add xxhdpi ActionBar Icons

2 participants

@maxme @nbradbury