Skip to content

[Dependency Updates] Update androidDesugarVersion to 1.1.8#18064

Merged
ParaskP7 merged 1 commit intotrunkfrom
deps/update-desugar-jdk-libs-to-1.1.8
Mar 9, 2023
Merged

[Dependency Updates] Update androidDesugarVersion to 1.1.8#18064
ParaskP7 merged 1 commit intotrunkfrom
deps/update-desugar-jdk-libs-to-1.1.8

Conversation

@ParaskP7
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 commented Mar 8, 2023

Parent #17559

This PR updates androidDesugarVersion to 1.1.8.

FYI:


Since 1.1.5 is outdated, with the latest v1 release (1.2.2) requiring an update to AGP 7.3.0 and above (see docs), while the latest v2 release (2.0.2) requiring an update to AGP 7.4.0 and above (see docs), the only possible update at this point is the 1.1.8.


PS: @ravishanker I added you as the main reviewer, randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.


To test:

  • See the dependency tree diff result and verify correctness.
  • Smoke test both, the WordPress and Jetpack apps, and see if they both work as expected.
  • In addition to the above smoke test, you can focus on testing push notifications and/or blogging reminders since this was why this library was introduced to this project in the first place (see here and here).

Regression Notes

  1. Potential unintended areas of impact

    • Not that I can think of, maybe push notifications and/or blogging reminders misbehaviour somehow, but I doubt it.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • See To test section above.
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Release Notes: N/A
Documentation: https://developer.android.com/studio/write/java8-support
Google Maven Repository: https://maven.google.com/web/index.html
?q=desug#com.android.tools:desugar_jdk_libs

------------------------------------------------------------------------

Since '1.1.5' is outdated, with the latest v1 release ('1.2.2')
requiring an update to AGP '7.3.0' and above, while the latest v2
release ('2.0.2') requiring an update to AGP '7.4.0' and above, the only
possible update at this point is the '1.1.8'.
@ParaskP7 ParaskP7 changed the title [Dependency Updates] Update to 1.1.8 [Dependency Updates] Update androidDesugarVersion to 1.1.8 Mar 8, 2023
@ParaskP7 ParaskP7 self-assigned this Mar 8, 2023
@ParaskP7 ParaskP7 added this to the Future milestone Mar 8, 2023
@ParaskP7 ParaskP7 requested review from a team and ravishanker March 8, 2023 14:33
@ParaskP7 ParaskP7 mentioned this pull request Mar 8, 2023
3 tasks
@wpmobilebot
Copy link
Copy Markdown
Contributor

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr18064-e8089d1.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commite8089d1
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Copy Markdown
Contributor

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr18064-e8089d1.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commite8089d1
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

Copy link
Copy Markdown
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating it 🚀

@ParaskP7
Copy link
Copy Markdown
Contributor Author

ParaskP7 commented Mar 9, 2023

Thanks for reviewing and testing this PR @ravishanker , you rock! 🙇 ❤️ 🚀

@ParaskP7 ParaskP7 merged commit 9fb4d89 into trunk Mar 9, 2023
@ParaskP7 ParaskP7 deleted the deps/update-desugar-jdk-libs-to-1.1.8 branch March 9, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants