Enable core library desugaring#14698
Enable core library desugaring#14698renanferrari merged 7 commits intofeature/blogging-remindersfrom
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
|
I think the |
|
I've run this lint task locally with 6GB of memory and it passed fine within a reasonable amount of time. Unfortunately in CircleCI, we are limited to 2GB of memory and it looks like that's not enough to get lint task done after these changes. The good news is that I plan to move the lint task to BuildKite during the upcoming HACK week which will not have this restriction and the task should pass fine. Assuming this is an optional PR, the best thing to do might be to postpone merging this PR for a bit. Sorry about that! |
Testing for #14698 lint failure issue by enabling desugaring here temporarily
Increasing heap size to see if it fixes CI heap max out issue
45ebab6 to
3bd9e55
Compare
This reverts commit 45ebab6.
…ordpress-mobile/WordPress-Android into feature/enable-core-library-desugaring
planarvoid
left a comment
There was a problem hiding this comment.
The app builds without problems. I'm getting the lint errors locally when running the CI command (lintWordpressVanillaRelease)
Errors found:
/Users/vojta/Development/wordpress/WordPress-Android/WordPress/src/main/java/org/wordpress/android/ui/media/MediaBrowserActivity.java:556: Error: Overriding method should call super.onRequestPermissionsResult [MissingSuperCall]
public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] results) {
~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/vojta/Development/wordpress/WordPress-Android/WordPress/src/main/java/org/wordpress/android/ui/media/MediaSettingsActivity.java:841: Error: Overriding method should call super.onRequestPermissionsResult [MissingSuperCall]
public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions,
~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/vojta/Development/wordpress/WordPress-Android/WordPress/src/main/java/org/wordpress/android/ui/ShareIntentReceiverActivity.java:152: Error: Overriding method should call super.onRequestPermissionsResult [MissingSuperCall]
public void onRequestPermissionsResult(int requestCode,
~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Moving this PR as well as #14719 to next milestone since 17.6 goes into code freeze today. |
This PR enables core library desugaring, which makes it possible for us to use Java 8+ APIs, most notably
java.timeandjava.util.stream.This was mainly motivated by the fact that we are going to be making quite a few operations with dates during the Notifications project and the
java.timeAPI can make that a lot less painful.To test:
Not much to test here. Just making sure it builds and all existing tests pass should be enough.
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.