[Jetpack Plugin Install] Reuse the tweaked UI for remote Jetpack install by thomashorta · Pull Request #18058 · wordpress-mobile/WordPress-Android

thomashorta · 2023-03-06T15:45:44Z

Update the existing "Remote Install" Flow to use this same updated flow (made with Compose). This flow is triggered when the user clicks a Jetpack feature (such as Stats) without having the Jetpack plugin installed on their self-hosted site.

Demo

Success Flow

issue-18045-jp-install-remote-success-blur.mov

Error Flow

issue-18045-jp-install-remote-error.mp4

To test

Set up a self-hosted site that has only no Jetpack plugins at all.

Install Jetpack OR WordPress app
Login using the site credentials
Select the self-hosted site from the site list
Tap a Jetpack feature, such as Stats
Testing the error state
1. Turn on Airplane mode
2. Start the Plugin Install Flow
3. Verify the UI is updated according to expectations
Testing the install flow
1. Close the Plugin Install flow
2. Turn off Airplane mode
3. Tap a Jetpack feature, such as Stats
4. Start the Plugin Install Flow
5. Verify the UI is updated according to expectations
6. Verify everything worked and the Jetpack plugin was installed

Regression Notes

Potential unintended areas of impact
Changes in installation behavior.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual test (it is working exactly as it was before).
What automated tests I added (or what prevented me from doing so)
Updated existing tests.

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

wpmobilebot · 2023-03-06T16:06:01Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr18058-d8c78c8.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`d8c78c8`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2023-03-06T16:06:31Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr18058-d8c78c8.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`d8c78c8`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2023-03-13T19:16:30Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18058-820cc08
	Commit	`820cc08`
	Direct Download	`wordpress-prototype-build-pr18058-820cc08.apk`

Note: Google Login is not supported on these builds.

peril-wordpress-mobile · 2023-03-13T19:18:21Z

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone
⚠️	PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

wpmobilebot · 2023-03-13T19:36:31Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18058-820cc08
	Commit	`820cc08`
	Direct Download	`jetpack-prototype-build-pr18058-820cc08.apk`

Note: Google Login is not supported on these builds.

RenanLukas

Thanks for the changes, @thomashorta

It works as expected. I've left a question, but LGTM

RenanLukas · 2023-03-15T21:42:03Z

...a/org/wordpress/android/ui/jetpackplugininstall/remoteplugin/JetpackRemoteInstallActivity.kt

+    }
+
+    override fun onBackPressed() {
+        if (viewModel.liveViewState.value?.showCloseButton == false) return


💡 Would it make sense to move this if and the trackWithSource call to the ViewModel?

I think it will not make a lot of difference in the code here as I still need to return some information saying the back should be blocked, but it's better in terms of testing the analytics. I will do the change.

… into issue/18045-jp-install-reuse-ui

RenanLukas

LGTM

thomashorta added [Type] Enhancement Jetpack Install Full Plugin labels Mar 6, 2023

thomashorta added this to the 22.0 milestone Mar 6, 2023

thomashorta requested review from RenanLukas and develric March 6, 2023 15:45

thomashorta self-assigned this Mar 6, 2023

thomashorta force-pushed the issue/18045-jp-install-reuse-ui branch from 267d304 to 6595050 Compare March 6, 2023 17:05

Base automatically changed from issue/18005-jp-full-plugin-ui-tweaks to trunk March 9, 2023 14:03

Thomas Horta added 10 commits March 13, 2023 14:50

using compose screens for old flow, needs clean-up

4723afa

clean up usage of Compose screen for remote and full plugin install

cf36be6

reorganize jp plugin install packages

ff3d017

fix checkstyle issues

746f011

fix lint and detekt issues

d108f8a

update some strings

31c0831

create a new HelpActivity origin for remote install

2cec7d9

fix unit tests

17d261f

fix progress indicator color in dark mode

fd7f42f

disable system back button when plugin is installing

96de52a

thomashorta force-pushed the issue/18045-jp-install-reuse-ui branch from d8c78c8 to 96de52a Compare March 13, 2023 18:59

remove unused dependency

b6f5906

thomashorta marked this pull request as ready for review March 13, 2023 19:18

RenanLukas approved these changes Mar 15, 2023

View reviewed changes

Thomas Horta added 2 commits March 16, 2023 15:09

Merge branch 'trunk' of github.com:wordpress-mobile/WordPress-Android…

152cd07

… into issue/18045-jp-install-reuse-ui

move tracking to viewmodel (PR comments)

820cc08

RenanLukas approved these changes Mar 16, 2023

View reviewed changes

thomashorta merged commit 6cb5e5b into trunk Mar 16, 2023

thomashorta deleted the issue/18045-jp-install-reuse-ui branch March 16, 2023 19:49

ovitrif mentioned this pull request Apr 26, 2023

[Dependency Updates] Add and Update androidxComposeBomVersion to 2023.01.00 #18319

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Jetpack Plugin Install] Reuse the tweaked UI for remote Jetpack install#18058

[Jetpack Plugin Install] Reuse the tweaked UI for remote Jetpack install#18058
thomashorta merged 13 commits intotrunkfrom
issue/18045-jp-install-reuse-ui

thomashorta commented Mar 6, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Mar 6, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Mar 6, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Mar 13, 2023 •

edited

Loading

Uh oh!

peril-wordpress-mobile bot commented Mar 13, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Mar 13, 2023 •

edited

Loading

Uh oh!

RenanLukas left a comment

Uh oh!

RenanLukas Mar 15, 2023

Uh oh!

thomashorta Mar 16, 2023

Uh oh!

RenanLukas left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

thomashorta commented Mar 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Demo

To test

Regression Notes

Uh oh!

wpmobilebot commented Mar 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Mar 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Mar 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented Mar 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Mar 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RenanLukas left a comment

Choose a reason for hiding this comment

Uh oh!

RenanLukas Mar 15, 2023

Choose a reason for hiding this comment

Uh oh!

thomashorta Mar 16, 2023

Choose a reason for hiding this comment

Uh oh!

RenanLukas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thomashorta commented Mar 6, 2023 •

edited

Loading

wpmobilebot commented Mar 6, 2023 •

edited

Loading

wpmobilebot commented Mar 6, 2023 •

edited

Loading

wpmobilebot commented Mar 13, 2023 •

edited

Loading

peril-wordpress-mobile bot commented Mar 13, 2023 •

edited

Loading

wpmobilebot commented Mar 13, 2023 •

edited

Loading