Conversation
…slated for feature removal overlays. Add line spacing
Contributor
|
|||||||||||
| 💡 Scan this QR code with your Android phone to download and install the APK directly on it. | ||
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 6dc6e9d | |
Contributor
|
|||||||||||
| 💡 Scan this QR code with your Android phone to download and install the APK directly on it. | ||
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 6dc6e9d | |
15 tasks
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Parent #17494
This PR shows the Open web links with Jetpack Overlay screen Only from Deep Link Intent. Launching from ReaderPostPagerActivity may possibly be handled in a separate PR, as it's quite a bit more complicated (It's not a Hilt activity/vm situation)
In this PR are the following modifications:
DeepLinkIntentReceiverActivityto a HiltEntryPointDeepLinkIntentReceiverViewModelto a HiltViewModelJetpackFeatureFullScreenOverlayfragment/viewmodel, as well as supporting classes (build ui/content state)To test:
Pre: Download the links_helper.zip file from this #17495
Test: Ensure that deep links are handled as normal
Test: Ensure that overlay is shown and dismiss works
open_web_lnks_with_jetpack_flowand restart the appTest: Ensure that overlay is shown and close works
Test: Ensure that you are forwarded to Jetpack and app setting has been set properly
Test: Ensure that values are cleared on logout & components are enabled
open_web_lnks_with_jetpack_flowand restart the appOpen web links with JetpacksettingRegression Notes
Potential unintended areas of impact
The overlay is not shown
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
Hooked into existing overlay logic
PR submission checklist:
RELEASE-NOTES.txtif necessary.