Conversation
…me deep link intent
…ty and into DeepLinkingCustomIntentReceiverActivity
15 tasks
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | c30d29d | |
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | c30d29d | |
3 tasks
AjeshRPai
approved these changes
Nov 21, 2022
Contributor
There was a problem hiding this comment.
I have gone through the code changes and have tested the changes by following the test instructions. Everything looks good to me 👍🏼 .
One log message I noticed while testing the changes
- Open the links_helper.html in a browser
- Tap on the “Jetpack Stats” Link
- Verify that the Jetpack app was launched
- Notice the following log message
Tracked: deep_link_not_default_handler, Properties: {"interceptor_classname":"com.google.android.apps.chrome.IntentDispatcher"}
Is that something expected?.
I am approving but not merging the PR so that @develric can have a look. Please merge when convenient.
Contributor
Author
Yes, that's a pre-existing capture from Thanks for the review. :) |
This was referenced Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #17494
The purpose of this PR is split the deep link receiver intent into two handlers; one for the custom
wordpress://scheme and the other for web/app links.Modifications Include
DeepLinkingCustomIntentReceiverActivitywas introduced as the handler for thewordpress:\\scheme deep links. Its sole purpose is to track and then forward the request toDeepLinkingIntentReceiverActivityfor handling as normal.DEEPLINK_CUSTOM_INTENT_RECEIVEDwas added to track the activityAndroidManifest,xmlwas updated to separate the intent filters.DeepLinkingIntentReceiverActivity.To test:
Prepare device
links_helper.htmlfile to your device (github doesn't support html file attachments)links_helper.html.zip
WordPress scheme test
Jetpack scheme test
Test that Web links are still functioning
Regression Notes
Potential unintended areas of impact
wordpress://deep links are not handled correctlyWhat I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
Added
DeepLinkingCustomIntentReceiverViewModelTestPR submission checklist:
RELEASE-NOTES.txtif necessary.