Jetpack Focus: Open web links with Jetpack - Add App Setting#17504
Merged
Jetpack Focus: Open web links with Jetpack - Add App Setting#17504
Conversation
…or getting package name
15 tasks
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | e8293a2 | |
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | e8293a2 | |
develric
reviewed
Nov 22, 2022
Contributor
develric
left a comment
There was a problem hiding this comment.
Code LGTM and I tested as per scenarios and worked well 👍 ! I only left a comment to better understand the default flags status. @zwarm 👋 , I know you were evaluating a slightly different approach in this series of PRs, let me know your thoughts about my only comment and if we are ok for this to land as it is and I'm fine with approving this one 🙇
Base automatically changed from
issue/17494-open-web-links-initialization
to
trunk
November 22, 2022 14:36
develric
approved these changes
Nov 22, 2022
Contributor
develric
left a comment
There was a problem hiding this comment.
Thanks @zwarm for setting the default feature flag value to false, I agree it makes sense while we complete the feature 👍 ! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #17494
This PR adds the “open web links with Jetpack” setting to the App Settings view.
This setting is only visible:
Merge Instructions
To test:
##Test: Setting is not shown when Feature Flag is enabled and JP is not installed##
##Test: Setting is not shown when Feature Flag is disabled and JP is not installed##
##Test: Setting is not shown within the JP app when FF is enabled##
##Test: Setting is shown within the WP app when FF is enabled and JP is installed##
Regression Notes
Potential unintended areas of impact
The app showing shows when it shouldn't
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual and unit testing
What automated tests I added (or what prevented me from doing so)
Add new tests to
DeepLinkOpenWebLinksWithJetpackHelperTestPR submission checklist:
RELEASE-NOTES.txtif necessary.