Jetpack Focus: Open web links with Jetpack - Initialization#17497
Merged
Jetpack Focus: Open web links with Jetpack - Initialization#17497
Conversation
…ll show the feature
…h jetpack overlay
15 tasks
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | ccb280d | |
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | ccb280d | |
3 tasks
Base automatically changed from
issue/17494-custom-scheme-deep-link-receiver
to
trunk
November 21, 2022 21:20
develric
reviewed
Nov 21, 2022
| buildConfigField "String", "TRACKS_EVENT_PREFIX", '"wpandroid_"' | ||
| buildConfigField "String", "PUSH_NOTIFICATIONS_APP_KEY", '"org.wordpress.android"' | ||
| buildConfigField "boolean", "ENABLE_QRCODE_AUTH_FLOW", "false" | ||
| buildConfigField "boolean", "ENABLE_OPEN_WEB_LINKS_WITH_JP_FLOW", "false" |
Contributor
There was a problem hiding this comment.
Does this mean it's disabled for WP and enabled for JP? If so I thought we needed the reverse maybe, wdyt?
Contributor
Author
There was a problem hiding this comment.
@develric This has been changed in a subsequent PR and will have no effect until the future.
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #17494
The purpose of this PR is to handle the initialization tasks needed to support the open web links with Jetpack flow.
Modifications Include
OpenWebLinksWithJetpackFlowFeatureConfigto manage the feature flowOPEN_WEB_LINKS_WITH_JETPACK_OVERLAY_LAST_SHOWN_TIMESTAMPDeepLinkOpenWebLinksWithJetpackHelperto manage the rules related to determine when to show the overlayDeepLinkOpenWebLinksWithJetpackHelperTestto test the rulesFirebaseRemoteConfigWrapperto support unit testing for frequency thresholdPackageManagerWrapperto support unit testing when checking if the deep link handler component is enabled/disabledMerge Instructions
To test:
(1) To test the overlay shown rules.
DeepLinkOpenWebLinksWithJetpackHelperTest(2) To test the feature flag
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
DeepLinkOpenWebLinksWithJetpackHelperTest
PR submission checklist:
RELEASE-NOTES.txtif necessary.