Skip to content

fix #1560 unauthorized error message for contributors#1656

Merged
nbradbury merged 2 commits intodevelopfrom
issue/1560-unauthorized-error-message-contributor
Jul 24, 2014
Merged

fix #1560 unauthorized error message for contributors#1656
nbradbury merged 2 commits intodevelopfrom
issue/1560-unauthorized-error-message-contributor

Conversation

@maxme
Copy link
Copy Markdown
Contributor

@maxme maxme commented Jul 24, 2014

fix #1560 unauthorized error message for contributors (instead of generic refresh error)

(Copied Media Library behaviour)

@maxme maxme added this to the 3.1 milestone Jul 24, 2014
@nbradbury nbradbury self-assigned this Jul 24, 2014
@nbradbury
Copy link
Copy Markdown
Contributor

This does show the "unauthorized" toast for comments, but at least in my case it isn't working for posts.
Debugging shows that at this line in ApiHelper.java result is not null but has a zero length, and no exception occurs. So the PostListFragment simply displays no posts (without a toast of any kind).

@maxme
Copy link
Copy Markdown
Contributor Author

maxme commented Jul 24, 2014

So the PostListFragment simply displays no posts (without a toast of any kind).

Yes it's the expected behavior. Contributors can save draft and "publish" their post as "Pending review" status. So they can refresh the post list, but they will see their own posts only. I agree it's weird when you're used to be a site admin ;) - I guess in your case, the contributor user doesn't have any post.

http://codex.wordpress.org/Roles_and_Capabilities

@nbradbury
Copy link
Copy Markdown
Contributor

In that case, :shipit: :)

nbradbury added a commit that referenced this pull request Jul 24, 2014
…d-error-message-contributor

fix #1560 unauthorized error message for contributors
@nbradbury nbradbury merged commit 5b047a4 into develop Jul 24, 2014
@nbradbury nbradbury deleted the issue/1560-unauthorized-error-message-contributor branch July 24, 2014 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding a blog to the app with "Contributor" role does show a wrong error message

2 participants