Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15077 in combination with #15085 & #15135.
windowLayoutInDisplayCutoutMode&windowLightNavigationBarproperties are only available in API >= 27, so this PR adds the styles that use this property tovalues-v27/styles.xmland removes the unavailable property from the defaultvalues/styles.xmlfile.To test:
This PR doesn't have any impact on the current UI, but there are a couple things the reviewer can check if they want to be extra sure.
developgo intovalues/styles.xmland find the usages for these properties. Android Studio will complain about them not being available before API 27 and offer to add the values tovalues-v27which results in this diff. (it won't remove the properties fromvalues/styles.xml, that needs to be done manually)WordPress.NoActionBar.DarkNavbar'sandroid:navigationBarColorin these two different places to different colors. This color will show up at the bottom navigation bar in the about page. Note that, if thevalues-v27color is completely removed, but thevaluesone is assigned to something like orange, the emulator with API >= 27 will still show it as black. This tells me that styles with the same name for different apis are not merged. They instead get assigned directly.The second test is really unnecessary, but I just wanted share what I did to understand the behavior.
Regression Notes
Potential unintended areas of impact
Incorrect styling for the changed
WordPress.Stories.ImmersiveandWordPress.NoActionBar.DarkNavbarstylesWhat I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested the UI as described in the testing steps
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.