Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
92d5780 to
12ddc20
Compare
3fe586d to
32bc09a
Compare
32bc09a to
90ccc1a
Compare
3 tasks
mokagio
approved these changes
Aug 5, 2021
Contributor
mokagio
left a comment
There was a problem hiding this comment.
Makes sense to me, for the little understanding of Android that I have.
Looking at the diff without whitespace changes confirms that the code that was inside if statements hasn't been modified 👍
I run the app on the Emulator and posted a story because I saw that a few stories fragments did change. 🤷♂️
WordPress/src/main/java/org/wordpress/android/ui/prefs/SummaryEditTextPreference.java
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/stories/intro/StoriesIntroDialogFragment.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/whatsnew/FeatureAnnouncementDialogFragment.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/mysite/QuickStartCardViewHolder.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/prefs/SummaryEditTextPreference.java
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/prefs/WPSwitchPreference.java
Show resolved
Hide resolved
This was referenced Nov 8, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15077 in combination with #15085 & #15138.
After an internal discussion, we decided to upgrade
minSdkto 24 as we have less than 5% of our users on the earlier versions of Android.I've also taken the opportunity to remove the
versionNameandversionCodevalues there were outdated.Besides upgrading the
minSdk, it removes obsolete checks for the earlier versions of sdk. I suggest turning on thehide whitespacesoption to review these changes.The only change that should be given extra attention to is 90ccc1a which merges
values-v23intovaluessince these values will always be available. This is also what the lint task recommended to do.Note that Automattic/stories-android#711 needs to be merged and thelibs/stories-androidsubmodule needs to be updated before this can be merged.To test:
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.