Skip to content

Remove setHasStableIds#13921

Merged
ParaskP7 merged 1 commit intodevelopfrom
issue/13328-restore-fix-adapater
Feb 1, 2021
Merged

Remove setHasStableIds#13921
ParaskP7 merged 1 commit intodevelopfrom
issue/13328-restore-fix-adapater

Conversation

@zwarm
Copy link
Copy Markdown
Contributor

@zwarm zwarm commented Jan 31, 2021

parent #13328

This PR addresses a comment in PR #13900

"When I click on "Restore site" it navigates me to Warning screen -> there is a noticeable animation glitch -> the cancel button appears after a delay and the confirmation button changes it's vertical position a bit"

To fix the issue I removed setHasStableIds(true) because the adapter is being reused and the view holders are not the same.

To test:

  • Launch the app
  • Navigate to Activity Log
  • Tap on the more menu for an item
  • Tap on Restore to this point
  • Tap on Restore Site to get to the warning view
  • Note that the Cancel button doesn't jump and confirmation button doesn't change position.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 16.7 milestone Jan 31, 2021
@zwarm zwarm requested review from a team and ParaskP7 and removed request for a team January 31, 2021 15:51
@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

@zwarm zwarm mentioned this pull request Jan 31, 2021
30 tasks
@ParaskP7 ParaskP7 self-assigned this Feb 1, 2021
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @zwarm !

I have reviewed and tested this PR as per the instruction, good fix! 🌟

@ParaskP7 ParaskP7 merged commit 0abe864 into develop Feb 1, 2021
@ParaskP7 ParaskP7 deleted the issue/13328-restore-fix-adapater branch February 1, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants