Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
3 tasks
|
You can test the changes on this Pull Request by downloading the APK here. |
malinajirka
reviewed
Jan 28, 2021
Contributor
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @zwarm! The changes LGTM. I've left just one comment.
Issues not related to this PR which we might want to add to our todo list:
- When I click on "Restore site" it navigates me to Warning screen -> there is a noticable animation glitch -> the cancel button appears after a delay and the confirmation button changes it's vertical position a bit (https://i.gyazo.com/ce0763521d7729b09b45ef048dd22110.gif)
- There is a noticable delay after I click on "Confirm restore site" on the warning screen, it takes +- 1-2 seconds before the apps navigates me to the progress screen.
WordPress/src/main/java/org/wordpress/android/ui/jetpack/restore/RestoreViewModel.kt
Outdated
Show resolved
Hide resolved
malinajirka
approved these changes
Jan 29, 2021
This was referenced Jan 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #13228
This PR enhances the Restore progress view by:
Also this PR adds back the "R.string" in
RestoreViewModelI don't know why AS keeps dropping it.Notes
To test:
-- Shows an indeterminate progress bar until progress > 0
-- Shows a message on the right hand side of the screen - this message is straight from the API
PR submission checklist:
RELEASE-NOTES.txtif necessary.