Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
9a4359e to
1542aa9
Compare
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @ashiagr!
I've left a few minor comments. One thing I noticed is that the confirmation dialog disappears after rotation - it's not a big deal, but we might want to fix it (feel free to add it into the backlog). Let me know what you think ;).
WordPress/src/main/java/org/wordpress/android/ui/jetpack/scan/ScanFragment.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/jetpack/scan/details/ThreatDetailsViewModel.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/jetpack/scan/details/ThreatDetailsViewModel.kt
Outdated
Show resolved
Hide resolved
...ss/src/test/java/org/wordpress/android/ui/jetpack/scan/details/ThreatDetailsViewModelTest.kt
Outdated
Show resolved
Hide resolved
|
Thanks so much for the review @malinajirka! There were nice ideas that improved code readability. Thank you!
Sounds good, added it to the backlog. |
…ts-usecase Issue/13326 fix threats usecase
Generated by 🚫 dangerJS |
malinajirka
left a comment
There was a problem hiding this comment.
Thanks for the changes! I've checked the code and smoke tested the app and it LGTM. Feel free to merge this when the CI finishes.
Parent #13326
This PR handles ignore threat action on the threat details screen.
Child PR for
IgnoreThreatUseCase: #13767It mimics behaviour on the web:
ignore.threat.web.mov
ignore.threat.mobile.mov
To test:
Prerequisite:
Repeat above steps and enable airplane mode after step 6. Notice that an error message is displayed and actions buttons are re-enabled.
(Tests included in
ThreatDetailsViewModelTest)Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.