Skip to content

Issue/13326 fix threats usecase#13796

Merged
ParaskP7 merged 3 commits intoissue/13326-ignore-threatfrom
issue/13326-fix-threats-usecase
Jan 19, 2021
Merged

Issue/13326 fix threats usecase#13796
ParaskP7 merged 3 commits intoissue/13326-ignore-threatfrom
issue/13326-fix-threats-usecase

Conversation

@ashiagr
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr commented Jan 18, 2021

Parent: #13795

This PR adds fix threats use case.

To test:
That FixThreatsUseCaseTest tests run fine and cover action results.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ashiagr ashiagr added this to the 16.6 milestone Jan 18, 2021
@ashiagr ashiagr self-assigned this Jan 18, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 18, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ashiagr ashiagr mentioned this pull request Jan 18, 2021
3 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 18, 2021

You can test the changes on this Pull Request by downloading the APK here.

@ashiagr ashiagr requested a review from ParaskP7 January 18, 2021 12:50
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @ashiagr !

I have reviewed and tested this PR, it all works as expected, kudos on the tests, they look so beautiful! ❤️

PS: I have left a comment just as an FYI, feel free to merge this PR.

@ashiagr
Copy link
Copy Markdown
Contributor Author

ashiagr commented Jan 19, 2021

Thanks for the review @ParaskP7! I liked the FYI part and included it in this PR itself. Need approval before I merge it :).

@ashiagr ashiagr requested a review from ParaskP7 January 19, 2021 08:49
@ParaskP7 ParaskP7 merged commit c30ab48 into issue/13326-ignore-threat Jan 19, 2021
@ParaskP7 ParaskP7 deleted the issue/13326-fix-threats-usecase branch January 19, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants