Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
antonis
approved these changes
Dec 7, 2020
Contributor
antonis
left a comment
There was a problem hiding this comment.
Great work @malinajirka 👍
I performed a few tests with different network conditions and post types posts/pages/stories with/without attached media and everything works as expected 🎉
The code changes look consistent👍
3 tasks
ParaskP7
added a commit
that referenced
this pull request
Feb 6, 2023
This dependency was added as part of this 82b0c50 commit (see PR below), which supported the use of GCMNetworkManager as a scheduler when Google Play Services is available for API levels <= 22. This was an optional dependency that helped with more reliable and performant background processing on older API versions as GCMNetworkManager on api <= 22 (see 2.2.0 release notes below). However, since this project is now on api >= 24 (see 'minSdkVersion'), this dependency is no longer necessary and thus can be removed. - PR: Issue/10572 update work manager #13542 #13542 - Work Manager 2.2.0: https://developer.android.com/jetpack/androidx/ releases/work#2.2.0 ------------------------------------------------------------------------ Also, the 'Dependency Analysis' plugin advised in favor of that removal, thus, it is most probably safe to do this removal at this point: Dependencies which should be removed or changed to runtime-only: runtimeOnly 'androidx.work:work-gcm:2.7.1' (was implementation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10572
I'm not able to replicate the issue. This PR updates
androidx.work:to it's newest stable version (2.4.0).Release notes are here.
I recommend reviewing this PR by commits:
lifecycle-extensionswas deprecated, this PR adds required dependencies explicitly (see this)ViewModelProviderswere removed with the deprecation oflifecycle-extensionsWorkManager.getInstance()withWorkManager.getInstance(context)To test - test on a newer API and API <= 22
Run
adb shell dumpsys jobscheduler(API 23+) and find the periodic task in the list.Note: I spent quite some time investigating why
JobInfofor the periodic task doesn't containIt does contain this line when running the app before this PR. I haven't find any information in docs about this change, but I tried switching the interval for the task to "15 minutes" and flex to "5 minutes" and verified it runs periodically.
PR submission checklist:
RELEASE-NOTES.txtif necessary.