Skip to content

Issue/13268 bind ui#13469

Merged
malinajirka merged 10 commits intodevelopfrom
issue/13268-bind-ui
Nov 26, 2020
Merged

Issue/13268 bind ui#13469
malinajirka merged 10 commits intodevelopfrom
issue/13268-bind-ui

Conversation

@malinajirka
Copy link
Copy Markdown
Contributor

@malinajirka malinajirka commented Nov 24, 2020

Partially fixes #13268

This PR maps data provided by the VM to the UI.

Merge instructions:

  1. Make sure Issue/13268 remote site #13450 is merged
  2. Remove "Not ready for merge" label
  3. Merge this PR

Notes:

  • The final designs are not ready yet, so the UI is not polished.
  • On item click logic is implemented in the next PR

To test:

  • Make sure the ActivityLogFiltersFeatureConfig is enabled
  1. My site -> Activity Log
  2. Click on "Activity Type" chip
  3. Notice a loading screen is shown
  4. Notice the loading screen gets replaced with the content screen after 1s

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@malinajirka malinajirka added this to the 16.3 milestone Nov 24, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 24, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@malinajirka malinajirka mentioned this pull request Nov 24, 2020
Merged
3 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 24, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@ParaskP7 ParaskP7 removed their request for review November 25, 2020 08:35
ashiagr
ashiagr approved these changes Nov 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested both success and error (by changing provider data) flow and everything worked as expected 👍.
Left a nitpick + one question.

Base automatically changed from issue/13268-remote-site-id to develop November 26, 2020 13:03
@malinajirka malinajirka merged commit 6d4ebee into develop Nov 26, 2020
@malinajirka malinajirka deleted the issue/13268-bind-ui branch November 26, 2020 13:03
@malinajirka malinajirka mentioned this pull request Nov 27, 2020
Closed
31 tasks
@ashiagr ashiagr mentioned this pull request Dec 11, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ParaskP7 ParaskP7 ParaskP7 left review comments

@zwarm zwarm Awaiting requested review from zwarm

+1 more reviewer

@ashiagr ashiagr ashiagr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Activity Log

Projects

None yet

Milestone

16.3

Development

Successfully merging this pull request may close these issues.

Jetpack Section: Activity Log

3 participants

@malinajirka @ashiagr @ParaskP7