Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
ashiagr
approved these changes
Nov 26, 2020
Contributor
ashiagr
left a comment
There was a problem hiding this comment.
LGTM 👍, just left one minor comment.
WordPress/src/main/java/org/wordpress/android/viewmodel/activitylog/ActivityLogViewModel.kt
Show resolved
Hide resolved
Contributor
|
LGTM 👍. |
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/activitylog/list/ActivityLogListFragment.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #13268
Merge instructions
Small PR in which the "remote site id" is passed to the ActivityLogTypeFilterViewModel. Since the upcoming PR is related just to the UI itself, I thought it'd be better to create a separate PR.
To test:
There is nothing to test yet. If you really want to test it, you can put a breakpoint here and check the the id is not null. However, we'll test this before we remove the feature flag so it's not necessary.
PR submission checklist:
RELEASE-NOTES.txtif necessary.