Error handling on Activity Type filter screen#13440
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
This was referenced Nov 23, 2020
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModel.kt # WordPress/src/test/java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModelTest.kt
ParaskP7
reviewed
Nov 23, 2020
Contributor
ParaskP7
left a comment
There was a problem hiding this comment.
Thanks a lot once again, and thanks for adding the dummy provider and tests, love both! ❤️
PS: I added a warning comment (
...main/java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModel.kt
Show resolved
Hide resolved
...src/main/java/org/wordpress/android/ui/activitylog/list/filter/DummyActivityTypesProvider.kt
Show resolved
Hide resolved
.../java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModelTest.kt
Show resolved
Hide resolved
.../java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModelTest.kt
Outdated
Show resolved
Hide resolved
.../java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModelTest.kt
Outdated
Show resolved
Hide resolved
.../java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModelTest.kt
Show resolved
Hide resolved
ashiagr
approved these changes
Nov 25, 2020
Contributor
ashiagr
left a comment
There was a problem hiding this comment.
Nice work @malinajirka, good use of dummy data providers 👍 for the time being.
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #13268
This PR adds error state with retry action to the activity type filter screen.
To test:
There is no UI yet, so there isn't anything to test.
PR submission checklist:
RELEASE-NOTES.txtif necessary.