[Modal Layout Picker] Cache the results of the fetched the layouts call#13105
Merged
[Modal Layout Picker] Cache the results of the fetched the layouts call#13105
Conversation
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/main/WPMainActivity.java # WordPress/src/main/java/org/wordpress/android/ui/pages/PagesFragment.kt # WordPress/src/main/java/org/wordpress/android/viewmodel/mlp/ModalLayoutPickerViewModel.kt # build.gradle
# Conflicts: # libs/gutenberg-mobile
# Conflicts: # WordPress/src/test/java/org/wordpress/android/viewmodel/mlp/ModalLayoutPickerViewModelTest.kt
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/mlp/ModalLayoutPickerFragment.kt # WordPress/src/main/java/org/wordpress/android/viewmodel/mlp/ModalLayoutPickerViewModel.kt # build.gradle
# Conflicts: # WordPress/src/main/java/org/wordpress/android/viewmodel/mlp/ModalLayoutPickerViewModel.kt
mkevins
approved these changes
Oct 16, 2020
Contributor
mkevins
left a comment
There was a problem hiding this comment.
I've reviewed and tested this via the steps in the description, and everything is working as expected. Tested all flows via Pixel 3a on a free and premium site, w/ the wasabi build. Also, I ran all unit tests, and everything is passing.
Great work Antonis! 🎉
# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java # WordPress/src/test/java/org/wordpress/android/viewmodel/mlp/ModalLayoutPickerViewModelTest.kt
# Conflicts: # build.gradle
# Conflicts: # WordPress/src/main/java/org/wordpress/android/viewmodel/mlp/ModalLayoutPickerViewModel.kt # WordPress/src/test/java/org/wordpress/android/viewmodel/mlp/ModalLayoutPickerViewModelTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#2456
Related PRs:
WordPress-FluxC-Android: Implements FETCH_BLOCK_LAYOUTS response CACHING WordPress-FluxC-Android#1718Description
This PR implements caching of the data as a result of the call made in #2443 and as modified by related issues.
Note
ImageManagerandGlidelibraryGutenbergTo test:
An easy way to test for these analytics is to debug the app and filter Logcat to look for the string
🔵 Tracked:Layout Picker should show when creating a new page from My Site or Site Pages the Modal Layout Picker appears.
Browse Modal Layout Picker
Expect to see picker loaded with the same results previously viewed.
Create Page
Browse Modal Layout PickerExpect to see the editor load with the populated data from the template
Preview Template
Browse Modal Layout PickerExpect to see the preview load with the cached data
Create Page From Preview
Preview TemplateExpect to see the editor load with the populated data from the template
PR submission checklist:
RELEASE-NOTES.txtif necessary.