Gutenberg/shallow submodules#11747
Merged
cameronvoell merged 3 commits intowoo/aztec-design-changesfrom Apr 24, 2020
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Contributor
Author
|
Updated the description with the git clone option to clone the particular branch, to avoid pulling the full submodules from |
|
You can test the changes on this Pull Request by downloading the APK here. |
cameronvoell
approved these changes
Apr 24, 2020
Contributor
cameronvoell
left a comment
There was a problem hiding this comment.
TestA and TestB worked perfectly. LGTM! ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses wordpress-mobile/gutenberg-mobile#2182
gb-mobile PR: wordpress-mobile/gutenberg-mobile#2183
This PR turns the gutenberg-mobile git submodule to a shallow one by default, to minimize the size pulled when casually cloning gutenberg-mobile.
Note: This PR is targeting another PR, only because the gutenberg-mobile bridge changes that PR introduces are already merged to gutenberg-mobile develop, and targeting develop will result to build errors.
That said, the issue at hand (JitPack seemingly taking too long to clone the gutenberg-mobile repo and bailing) is plaguing this PR anyway, by failing many of its CI jobs.
To test A
git clone --single-branch --branch gutenberg/shallow-submodules git@github.com:wordpress-mobile/WordPress-Android.gitto pull the repo. Wait until that finishes.cd WordPress-Androidto go into the clonegit submodule update --init --recursiveand wait until it finishescd libs/gutenberg-mobileto go into the gb-mobile submodulegit rev-parse --is-shallow-repositoryto verify it's a shallow clone. It should returntrue.gutenbergandjetpacksubmodules.git fetch --unshallowto pull the whole submodule history, to verify that it can be done.git rev-parse --is-shallow-repositoryshould returnfalseafter this.To test B
git clone --single-branch --branch gutenberg/shallow-submodules git@github.com:wordpress-mobile/WordPress-Android.gitto pull the repo. Wait until that finishes.cd WordPress-Androidto go into the clonegit submodule update --init --recursive --no-recommend-shallowand wait until it finishescd libs/gutenberg-mobileto go into the gbm-mobile submodulegit rev-parse --is-shallow-repositoryto verify it's a not shallow clone. It should returnfalse.gutenbergandjetpacksubmodules) are also not shallowPR submission checklist:
RELEASE-NOTES.txtif necessary.