Turn the git submodules to shallow by default#2183
Merged
cameronvoell merged 1 commit intodevelopfrom Apr 24, 2020
Merged
Conversation
3 tasks
Contributor
Author
|
Updated the description with the git clone option to clone the particular branch, to avoid pulling the full submodules from develop. |
cameronvoell
approved these changes
Apr 24, 2020
Contributor
cameronvoell
left a comment
There was a problem hiding this comment.
Test A and B both worked for me ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2182
WPAndroid side PR: TBD
Our current theory is that the submodules are large enough and JitPack is not cloning then shallowly so, this PR marks the submodules as shallow by default in an attempt to minimize the size of their casual cloning.
The typical way we pull the submodules is by issuing
git submodule update --init --recursive. The same command can still be used and it will pull a shallow copy of the submodules.If you need to pull the whole history instead, the initial pull after a fresh clone can be:
git submodule update --no-recommend-shallow --init --recursiveTo test A
git clone --single-branch --branch try/shallow-submodules git@github.com:wordpress-mobile/gutenberg-mobile.gitto pull the repo. Wait until that finishes.cd gutenberg-mobileto go into the clonegit submodule update --init --recursiveand wait until it finishescd gutenbergto go into the Gutenberg submodulegit rev-parse --is-shallow-repositoryto verify it's a shallow clone. It should returntrue.git fetch --unshallowto pull the whole submodule history, to verify that it can be done.jetpack) too, to verify that that one is shallow too and it can be unshallowed.To test B
git clone --single-branch --branch try/shallow-submodules git@github.com:wordpress-mobile/gutenberg-mobile.gitto pull the repo. Wait until that finishes.cd gutenberg-mobileto go into the clonegit submodule update --init --recursive --no-recommend-shallowand wait until it finishescd gutenbergto go into the Gutenberg submodulegit rev-parse --is-shallow-repositoryto verify it's a not shallow clone. It should returnfalse.jetpack) too, to verify that that one is not shallow too.PR submission checklist:
RELEASE-NOTES.txtif necessary.