Skip to content

Issue/nuke calypso styles#11507

Merged
develric merged 3 commits intoissue/use-material-alert-dialogfrom
issue/nuke-calypso-styles
Mar 25, 2020
Merged

Issue/nuke calypso styles#11507
develric merged 3 commits intoissue/use-material-alert-dialogfrom
issue/nuke-calypso-styles

Conversation

@khaykov
Copy link
Copy Markdown
Contributor

@khaykov khaykov commented Mar 23, 2020 •
edited
Loading

#11503 and #11505 need to be merged first.

This PR removes CalypsoTheme, which was already inheriting from main WordPress theme.

To test:

  • There is nothing particular to test. Make sure the app builds and launches correctly.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@khaykov khaykov added this to the 14.6 milestone Mar 23, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Mar 23, 2020

You can test the changes on this Pull Request by downloading the APK here.

@develric develric self-assigned this Mar 25, 2020
develric
develric approved these changes Mar 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @khaykov , it compiles, it runs (on API 23, 28 and 29). Also switched to dark mode, just to enjoy it 😊! LGTM 👍!

@develric develric merged commit 741b3d7 into issue/use-material-alert-dialog Mar 25, 2020
@develric develric deleted the issue/nuke-calypso-styles branch March 25, 2020 11:49
@khaykov
Copy link
Copy Markdown
Contributor Author

khaykov commented Mar 25, 2020

@develric Ah, this got merged into the wrong branch :) It was dependent on #11505 and targeted towards issue/use-material-alert-dialog to avoid extra code during the review. I'll resubmit it towards correct branch :)

@khaykov khaykov restored the issue/nuke-calypso-styles branch March 25, 2020 16:02
@khaykov khaykov mentioned this pull request Mar 25, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@planarvoid planarvoid Awaiting requested review from planarvoid

@renanferrari renanferrari Awaiting requested review from renanferrari

@theck13 theck13 Awaiting requested review from theck13

1 more reviewer

@develric develric develric approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@develric develric

Labels

None yet

Projects

None yet

Milestone

14.6

Development

Successfully merging this pull request may close these issues.

2 participants

@khaykov @develric