[Gutenberg] Media & Text - return the media type#10567
Merged
koke merged 6 commits intowordpress-mobile:developfrom Oct 10, 2019
Merged
[Gutenberg] Media & Text - return the media type#10567koke merged 6 commits intowordpress-mobile:developfrom
koke merged 6 commits intowordpress-mobile:developfrom
Conversation
1 task
2 tasks
mkevins
approved these changes
Oct 10, 2019
Contributor
mkevins
left a comment
There was a problem hiding this comment.
I've tested this on Android with the additional changes here: wordpress-mobile/gutenberg-mobile#1412 and here: wordpress-mobile/gutenberg-mobile#1400. This is looking good. Nice work @geriux ! tada
|
You can test the changes on this Pull Request by downloading the APK here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#1378
It includes changes from (#10560) that had to be reverted from develop and the reference to the gutenberg-mobile PR
To test:
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.