Skip to content

[Gutenberg] Revert "revert-multiple-media-pr"#10560

Merged
mkevins merged 3 commits intodevelopfrom
issue/revert-revert-multiple-media-pr
Oct 9, 2019
Merged

[Gutenberg] Revert "revert-multiple-media-pr"#10560
mkevins merged 3 commits intodevelopfrom
issue/revert-revert-multiple-media-pr

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Oct 3, 2019

This PR reverts the reverted PR merge on #10558, merging into a temporary gutenberg/develop branch.

This reverts commit 5c2fa2e, reversing
changes made to d944b59.

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom
Revert "Merge pull request #10558 from wordpress-mobile/issue/revert-…
d0c9da3 
…multiple-media-pr"

This reverts commit 5c2fa2e, reversing
changes made to d944b59.
@etoledom etoledom added this to the 13.5 milestone Oct 3, 2019
@etoledom etoledom requested review from mkevins and pinarol October 3, 2019 07:34
@etoledom etoledom self-assigned this Oct 3, 2019
@etoledom etoledom changed the base branch from develop to gutenberg/develop October 3, 2019 07:34
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Oct 3, 2019 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@geriux geriux mentioned this pull request Oct 3, 2019
Merged
2 tasks
@mkevins mkevins mentioned this pull request Oct 7, 2019
Merged
2 tasks
pinarol
pinarol approved these changes Oct 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etoledom etoledom changed the base branch from gutenberg/develop to develop October 8, 2019 14:02
@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Oct 8, 2019

Update: I have

  • Moved the target back to develop
  • Updated gutenberg-mobile JS Bundle to contain the latest updates including the release 1.14.
  • Updated the gutenberg-mobile reference to develop
  • Updated this branch from WPAndroid:develop.

@mkevins @pinarol - If it looks good to you, please feel free to merge.

mkevins
mkevins approved these changes Oct 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed the revert-revert is correct. Thanks for your help on this @etoledom ! 😄 👍

@mkevins mkevins merged commit 2c0eef5 into develop Oct 9, 2019
@oguzkocer oguzkocer deleted the issue/revert-revert-multiple-media-pr branch April 15, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinarol pinarol pinarol approved these changes

+1 more reviewer

@mkevins mkevins mkevins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@etoledom etoledom

Labels

None yet

Projects

None yet

Milestone

13.5

Development

Successfully merging this pull request may close these issues.

3 participants

@etoledom @pinarol @mkevins