Gutenberg/Android X: Apply Java 1.8 compileOptions even when building from binaries#10055
Merged
daniloercoli merged 1 commit intogutenberg/android_x_migrationfrom Jun 18, 2019
Merged
Conversation
daniloercoli
approved these changes
Jun 18, 2019
Contributor
daniloercoli
left a comment
There was a problem hiding this comment.
Looks good! Will merge this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added this conditional in #9882 in order to fix tests after
react-native-videowas introduced. It does not seem to be needed anymore and removing it should unblock the Android X migration (#10020).It will fix the build on #10020 with
wp.BUILD_GUTENBERG_FROM_SOURCE=false.To test:
With
wp.BUILD_GUTENBERG_FROM_SOURCE=false:./gradlew WordPress:assembleVanillaDebug./gradlew WordPress:assembleVanillaDebugAndroidTestWith
wp.BUILD_GUTENBERG_FROM_SOURCE=true:./gradlew WordPress:assembleVanillaDebug./gradlew WordPress:assembleVanillaDebugAndroidTestUpdate release notes:
RELEASE-NOTES.txt.