Fix Android Test build errors caused by Gutenberg change#9882
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes from #9644 are causing build errors for our connected tests. You can see the failure on CircleCI here.
The problem is that the new
compileOptionsentryisn't playing nicely with the Android tests. I'm not sure why this is. Since the setting is only needed when building from source, I have added a conditional check around it.
Note:
assembleVanillaDebugAndroidTestwill still fail when building Gutenberg from source. I tried moving the Gradle config toWordPressEditorbut that didn't work.To test:
With
wp.BUILD_GUTENBERG_FROM_SOURCE=false:./gradlew WordPress:assembleVanillaDebug./gradlew WordPress:assembleVanillaDebugAndroidTestWith
wp.BUILD_GUTENBERG_FROM_SOURCE=true:./gradlew WordPress:assembleVanillaDebugUpdate release notes:
RELEASE-NOTES.txt.