Adding public access level HeaderFormatter#1108
Merged
Conversation
diegoreymendez
approved these changes
Dec 17, 2018
Contributor
diegoreymendez
left a comment
There was a problem hiding this comment.
Tested through the referenced PR.
koke
added a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Dec 20, 2018
The latest version doesn't contain a change that's essential for Gutenberg to build: wordpress-mobile/AztecEditor-iOS#1108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for Gutenberg's RNAztecView.
Implemented in this PR wordpress-mobile/react-native-aztec#98
This will be merged if the previously mentioned PR is approved with the proposed solution, or if any other solution need these changes.
To test: