Last char is when the length is now zero#892
Conversation
|
The unit tests seem to fail on CI (all of them, which is weird) but they are green locally. |
|
Confirmed this changes fixes wordpress-mobile/gutenberg-mobile#1865 on the basic case, however I found one way to still have merge on delete not work, when you add a style to the text that extends farther to the right from what you delete at the front of the text before the attempted merge. (the merge on delete never happens in the attached GIF, don't be fooled by GIF restart :-P ) I think the remaining issue would be pretty rare, and this fix is still an improvement, so we could document the remaining issue, and still merge this fix. What do you think @hypest ?
|
|
Thanks Cameron, yeah, we could tackle the subcase in a separate PR, but since I'm not even 100% about the current fix, let's also hear from @khaykov about the fix, since there might be more context. |
|
Since we need this fix on the v1.22 release of the block editor, let's move forward, wdyt @cameronvoell ? |
There was a problem hiding this comment.
Approving since this change should fix the vast majority of instances of wordpress-mobile/gutenberg-mobile#1865.
I also recommend merging despite the failed CI Unit tests, since @mchowning and this comment mention that unit tests were working fine locally.
|
Going ahead and merging since the tests are passing locally and this is "blocking" the 1.22 block editor release. 🥁 |
Experimental PR to fix the gutenberg-mobile issue: wordpress-mobile/gutenberg-mobile#1865
Testing the original issues to be sure this PR doesn't break them
From #398:
Test 1 (testing the format while the keyboard is closed): ✅
Test 2 (format on the next line): ❌ This test seems to fail anyway even on
develop(d2baefd) so, ignoring for this PRTest 3 (Backspace last char, backspace to clear format): ✅
From #357:
Test:⚠️ issue not happening but, the format did not continue to the next line as the test steps mention.
From #362:
Test: ✅
To test
Using the gutenberg-mobile PR wordpress-mobile/gutenberg-mobile#1867 confirm that the issue of merging two paragraph blocks (wordpress-mobile/gutenberg-mobile#1865) is not happening anymore.
Make sure strings will be translated:
strings.xmlas a part of the integration PR.